[FIX] sale: don't skip super on validation post-process

Versions
--------
- 18.0+

Issue
-----
`super` isn't called on `_post_process` for confirmed validation
transactions.

Cause
-----
A fix that prevented the sending of mail for validation transactions
added a `continue` in a loop, which skips over the `super` call in the
loop.

Solution
--------
Instead of `continue`, add an `if` check to see if we want to send mail.

closes odoo#232232

X-original-commit: 6575954
Signed-off-by: Victor Feyens (vfe) <[email protected]>
Signed-off-by: Levi Siuzdak <[email protected]>

Author: lvsz

addons/sale/models/payment_transaction.py

@@ -83,10 +83,9 @@ def _post_process(self):
         )._post_process()
 
         for done_tx in self.filtered(lambda tx: tx.state == 'done'):
-            confirmed_orders = done_tx._check_amount_and_confirm_order()
-            if done_tx.operation == 'validation':
-                continue
-            (done_tx.sale_order_ids - confirmed_orders)._send_payment_succeeded_for_order_mail()
+            if done_tx.operation != 'validation':
+                confirmed_orders = done_tx._check_amount_and_confirm_order()
+                (done_tx.sale_order_ids - confirmed_orders)._send_payment_succeeded_for_order_mail()
 
             auto_invoice = self.env['ir.config_parameter'].sudo().get_bool('sale.automatic_invoice')
             if auto_invoice: