Switch tests to OCaml 5.4

Author: hhugo

.github/workflows/js_of_ocaml.yml

@@ -25,6 +25,7 @@ jobs:
           - "5.0"
           - "5.1"
           - "5.2"
+          - "5.3"
         skip-test:
           - true
         skip-doc:
@@ -59,7 +60,7 @@ jobs:
             skip-doc: true
           - os: ubuntu-latest
             os-name: Ubuntu
-            ocaml-compiler: "5.3"
+            ocaml-compiler: "5.4"
             skip-effects: false
             skip-test: false
             skip-doc: false
@@ -72,31 +73,24 @@ jobs:
             # Note this OCaml compiler is bytecode only
           - os: ubuntu-latest
             os-name: Ubuntu
-            ocaml-name: "5.3.0+32bit"
-            ocaml-compiler: "ocaml-variants.5.3.0+options,ocaml-option-32bit"
+            ocaml-name: "5.4.0+32bit"
+            ocaml-compiler: "ocaml-variants.5.4.0+options,ocaml-option-32bit"
             skip-effects: true # disabled for the same reason than `skip-test`
             skip-test: true # the `time_now.0.17` package is pulled and doesn't work in 32 bits :(
             skip-doc: true
           - os: macos-latest
             os-name: MacOS
-            ocaml-compiler: "5.3"
+            ocaml-compiler: "5.4"
             skip-effects: true
             skip-test: false
             skip-doc: true
           - os: windows-latest
             os-name: Windows
-            ocaml-compiler: "5.3"
+            ocaml-compiler: "5.4"
             skip-effects: false
             skip-test: false
             skip-doc: true
-          - os: ubuntu-latest
-            os-name: Ubuntu
-            ocaml-name: "5.4-alpha1"
-            ocaml-compiler: "ocaml-compiler.5.4.0~alpha1"
-            skip-effects: true
-            skip-test: true
-            skip-doc: true
-
+ 
     runs-on: ${{ matrix.os }}
 
     name:

.github/workflows/wasm_of_ocaml.yml

@@ -26,6 +26,7 @@ jobs:
           - "5.0"
           - "5.1"
           - "5.2"
+          - "5.4"
         separate_compilation:
           - true
         jane_street_tests:
@@ -116,7 +117,6 @@ jobs:
         run: |
           opam repo add js janestreet/opam-repository
           opam install opam-format
-          opam pin add ppxlib -n 0.35.0
           opam exec -- dune exec --root wasm_of_ocaml tools/ci_setup.exe
 
       - name: Pin Jane Street packages

compiler/tests-ocaml/lib-list/test.ml

@@ -68,13 +68,11 @@ let () =
   assert (List.take 3 [1; 2; 3; 4; 5] = [1; 2; 3]);
   assert (List.take 3 [1; 2] = [1; 2]);
   assert (List.take 3 [] = []);
-  assert ((try List.take (-1) [1; 2] with Invalid_argument _ -> [999]) = [999]);
   assert (List.take 0 [1; 2] = []);
   assert (List.drop 6 hello_world = world);
   assert (List.drop 3 [1; 2; 3; 4; 5] = [4; 5]);
   assert (List.drop 3 [1; 2] = []);
   assert (List.drop 3 [] = []);
-  assert ((try List.drop (-1) [1; 2] with Invalid_argument _ -> [999]) = [999]);
   assert (List.drop 0 [1; 2] = [1; 2]);
   assert (List.take_while (fun x -> x < 3) [1; 2; 3; 4; 1; 2; 3; 4]
           = [1; 2]);

compiler/tests-toplevel/test_toplevel.expected

@@ -2,6 +2,6 @@ hello
 - : int = 2
 Line 4, characters 2-4:
 Error: Syntax error
-Line 5, characters 0-16:
-Error: Unbound module "Missing_module"
+Line 5, characters 0-14:
+Error: Unbound module Missing_module
 val y : float = 0.333333333333333315