-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Drivers: MPSL: Reduce flash radio sync timeout for Mesh use cases #25723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses a performance regression in Bluetooth Mesh applications caused by recent changes in MPSL's usage of the radio sync timeout configuration. The PR reduces the default timeout from 10ms to 5ms specifically for Mesh use cases to restore acceptable roundtrip message timing without compromising flash operation priority.
Key Changes:
- Reduced flash radio sync timeout to 5ms for BT_MESH configurations to improve roundtrip message latency
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CI InformationTo view the history of this post, click the 'edited' button above Inputs:Sources:sdk-nrf: PR head: a8994f064b5e03bf7f7f8fcb5ac1d47377d65d48 more detailssdk-nrf:
Github labels
List of changed files detected by CI (1)Outputs:ToolchainVersion: df3cc9d822 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
|
You can find the documentation preview for this PR here. |
bf880da to
ff44918
Compare
After changes in how MPSL uses the CONFIG_SOC_FLASH_NRF_RADIO_SYNC_MPSL_NORMAL_PRIORITY_TIMEOUT_US value, Mesh applications started observing some slowdown in roundtrip point-to-point message and response. This is because Mesh now needs to wait for the entire timeout as part of a roundtrip. Decreasing the timeout to 5ms moves us close to where we were before the recent changes to MPSL, without over-prioritizing flash timeslots. Signed-off-by: Ludvig Jordet <[email protected]>
ff44918 to
a8994f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@nrfconnect/ncs-co-drivers could you please take a look at this now? We need to get this in for NCS 3.2.0 |
jfischer-no
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
After changes in how MPSL uses the
CONFIG_SOC_FLASH_NRF_RADIO_SYNC_MPSL_NORMAL_PRIORITY_TIMEOUT_US value, Mesh applications started observing some slowdown in roundtrip point-to-point message and response. This is because Mesh now needs to wait for the entire timeout as part of a roundtrip. Decreasing the timeout to 5ms moves us close to where we were before the recent changes to MPSL, without over-prioritizing flash timeslots.