Modify MCUboot to use PSA key_id_t for key type in AES encryption context #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-nordic
force-pushed
the
psa_use_key_id
branch
from
b05f9e3 to
f9e2dfd
Compare
tomchy
approved these changes
Nov 7, 2025
tomchy
reviewed
Nov 7, 2025
| return mbedtls_aes_setkey_enc(ctx, k, BOOT_ENC_KEY_SIZE * 8); | ||
| } | ||
|
|
||
| static inline int bootutil_aes_ctr_encrypt(bootutil_aes_ctr_context *ctx, uint8_t *counter, const uint8_t *m, uint32_t mlen, size_t blk_off, uint8_t *c) |
Contributor
There was a problem hiding this comment.
Ideally, I'd prefer to have docstrings inside the interface header, but since this is a [fromtree] commit, I'm not going to require them at this stage.
Split definitions to crypto backend specific headers. Signed-off-by: Dominik Ermel <[email protected]> (cherry picked from commit 5a161e4cc1cd5329c073d996f0300d2661c6b768)
Store psa_key_id_t key in AES context instead of RAW key. Signed-off-by: Dominik Ermel <[email protected]> (cherry picked from commit e92551838e18b6219af0891a18a757e538bd3ff6)
de-nordic
force-pushed
the
psa_use_key_id
branch
from
f9e2dfd to
818e6fa
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two commits from upstream:
Replacement of raw key array in encryption context, with psa_key_id_t, has reduced MCUboot binary size by ~224 bytes, for non-KMU and non-log-dbg build; small amount of RAM is saved also.