tools: run tests --without-amaro on test-shared macOS
#60902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
the
meta
targos
previously approved these changes
Nov 30, 2025
aduh95
added
author ready
aduh95
force-pushed
the
disable-build-options-ci
branch
from
95caad8 to
119dabb
Compare
Contributor
Author
|
Tests are completely broken on builds without SQLite, fixing it would be out of scope for this PR |
aduh95
force-pushed
the
disable-build-options-ci
branch
from
119dabb to
86fa3cb
Compare
aduh95
changed the title
--without-amaro on test-shared macOS
marco-ippolito
approved these changes
Nov 30, 2025
This was referenced Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have no CI that run the tests with those options. Rather than introducing an additional job, we can reuse that job which is already kinda redundant anyway (we already test with macOS, and we already test with shared-libs on Linux).
I did not include
--without-intland--without-sslbecause we already have Jenkins CI jobs dedicated to those.EDIT: because each of the options were broken on its own right, I'm splitting this in separate PRs. This one only enables
--without-amaroas the fix for its tests has already landed.