Skip to content

fixes #25210; VM error when passing object field ref to proc(var T): var T #25213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 15, 2025
Merged

fixes #25210; VM error when passing object field ref to proc(var T): var T #25213

merged 3 commits into from
Oct 15, 2025

Conversation

@ringabout
Copy link
Member

@ringabout ringabout commented Oct 9, 2025 •
edited
Loading

fixes #25210
no longer transform addr(obj.field[]) into obj.field to keep the addressing needed for VM

@ringabout ringabout changed the title test deref fixes #25210; VM error when passing object field ref to proc(var T): var T Oct 9, 2025
@ringabout ringabout marked this pull request as ready for review October 9, 2025 14:29
@ringabout
Copy link
Member Author

ringabout commented Oct 10, 2025

breaks the JS, I guess I could make some changes on JS backend or something

@Araq Araq merged commit fb4a82f into devel Oct 15, 2025
21 checks passed
@Araq Araq deleted the pr_Hupen branch October 15, 2025 05:21
@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2025

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from fb4a82f

Hint: mm: orc; opt: speed; options: -d:release
183147 lines; 8.140s; 661.703MiB peakmem

narimiran pushed a commit that referenced this pull request Oct 15, 2025
@ringabout @narimiran
fixes #25210; VM error when passing object field ref to proc(var T): …
8b8272d 
…var T (#25213)

fixes #25210
no longer transform `addr(obj.field[])` into `obj.field` to keep the
addressing needed for VM

(cherry picked from commit fb4a82f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

VM error when passing object field ref to proc(var T): var T

3 participants

@ringabout @Araq