Throw for LINQ DML on filter

Author: bahusoid

src/NHibernate.Test/Async/LinqBulkManipulation/Fixture.cs

@@ -1158,6 +1158,18 @@ public async Task DeleteSyntaxWithCompositeIdAsync()
 			}
 		}
 
+		[Test]
+		public async Task DeleteOnFilterThrowsAsync()
+		{
+			using (var s = OpenSession())
+			using (s.BeginTransaction())
+			{
+				var a = await (s.Query<SimpleEntityWithAssociation>().Take(1).SingleOrDefaultAsync());
+				var query = a.AssociatedEntities.AsQueryable();
+				Assert.That(() => query.Delete(), Throws.InstanceOf<NotSupportedException>());
+			}
+		}
+
 		#endregion
 	}
-}
+}

src/NHibernate.Test/LinqBulkManipulation/Fixture.cs

@@ -1199,6 +1199,18 @@ public void DeleteOnProjectionThrows()
 			}
 		}
 
+		[Test]
+		public void DeleteOnFilterThrows()
+		{
+			using (var s = OpenSession())
+			using (s.BeginTransaction())
+			{
+				var a = s.Query<SimpleEntityWithAssociation>().Take(1).SingleOrDefault();
+				var query = a.AssociatedEntities.AsQueryable();
+				Assert.That(() => query.Delete(), Throws.InstanceOf<NotSupportedException>());
+			}
+		}
+
 		#endregion
 	}
-}
+}

src/NHibernate/Async/Linq/DefaultQueryProvider.cs

@@ -72,12 +72,15 @@ protected virtual Task<object> ExecuteQueryAsync(NhLinqExpression nhLinqExpressi
 
 		public Task<int> ExecuteDmlAsync<T>(QueryMode queryMode, Expression expression, CancellationToken cancellationToken)
 		{
+			if (Collection != null)
+				throw new NotSupportedException("DML operations are not supported for filters.");
 			if (cancellationToken.IsCancellationRequested)
 			{
 				return Task.FromCanceled<int>(cancellationToken);
 			}
 			try
 			{
+
 				var nhLinqExpression = new NhLinqDmlExpression<T>(queryMode, expression, Session.Factory);
 
 				var query = Session.CreateQuery(nhLinqExpression);

src/NHibernate/Linq/DefaultQueryProvider.cs

@@ -265,6 +265,9 @@ public virtual void SetResultTransformerAndAdditionalCriteria(IQuery query, NhLi
 
 		public int ExecuteDml<T>(QueryMode queryMode, Expression expression)
 		{
+			if (Collection != null)
+				throw new NotSupportedException("DML operations are not supported for filters.");
+
 			var nhLinqExpression = new NhLinqDmlExpression<T>(queryMode, expression, Session.Factory);
 
 			var query = Session.CreateQuery(nhLinqExpression);