Exporting shapes to Region of interest objects #544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a draft pr right now and doesn't contain testcases nor has been tested with precommit. This PR is just for feedback from mentors.
What is this PR
Why is this PR needed?
issue #378
What does this PR do?
Creates a ROI layer using the polygon and line in the roi folder.
Added another widget which lets users export shapes as a ROI Layer with custom names.
Roi Layers then in turn can be exported to JSON or .h5 file (Header of the file is similar to the one used by DeepLabCut ie ROI can be loaded through the load tracked data widget)
Made a separate load roi feature is the export is in JSON format.
Which are overlapped with the original shapes layer.
Basically I have I have tried to implement all the functionalities mentioned by @niksirbi in PR #489
This is still a draft PR as I am not sure if the implementation is exactly what was required and the .h5 file give a flipped results sometimes (Working on the later)
Any feedback would be really helpful!
References
Please reference any existing issues/PRs that relate to this PR.
How has this PR been tested?
Please explain how any new code has been tested, and how you have ensured that no existing functionality has changed.
Is this a breaking change?
If this PR breaks any existing functionality, please explain how and why.
Does this PR require an update to the documentation?
If any features have changed, or have been added. Please explain how the
documentation has been updated.
Checklist: