fixes #933 update javadoc and a test case (#934)

Author: stevehu

src/main/java/com/networknt/schema/AbsoluteIri.java

@@ -31,7 +31,7 @@ public class AbsoluteIri {
     /**
      * Constructs a new IRI given the value.
      * 
-     * @param value
+     * @param value String
      */
     public AbsoluteIri(String value) {
         this.value = value;

src/main/java/com/networknt/schema/Annotations.java

@@ -64,6 +64,7 @@ public class Annotations {
      * Gets the default annotation allow list.
      * 
      * @param metaSchema the meta schema
+     * @return the default annotation allow set
      */
     public static Set<String> getDefaultAnnotationAllowList(JsonMetaSchema metaSchema) {
         boolean unevaluatedProperties = metaSchema.getKeywords().get("unevaluatedProperties") != null;
@@ -82,6 +83,7 @@ public static Set<String> getDefaultAnnotationAllowList(JsonMetaSchema metaSchem
      * Gets the default annotation allow list predicate.
      * 
      * @param metaSchema the meta schema
+     * @return the default annotation allow list predicate
      */
     public static Predicate<String> getDefaultAnnotationAllowListPredicate(JsonMetaSchema metaSchema) {
         boolean unevaluatedProperties = metaSchema.getKeywords().get("unevaluatedProperties") != null;

src/main/java/com/networknt/schema/OutputFormat.java

@@ -37,8 +37,9 @@ default void customize(ExecutionContext executionContext, ValidationContext vali
     /**
      * Formats the validation results.
      * 
-     * @param validationMessages
-     * @param executionContext
+     * @param validationMessages the validation messages
+     * @param executionContext  the execution context
+     * @param validationContext the validation context
      * @return the result
      */
     T format(Set<ValidationMessage> validationMessages, ExecutionContext executionContext,

src/main/java/com/networknt/schema/SchemaLocation.java

@@ -188,7 +188,7 @@ public static class Fragment {
         /**
          * Parses a string representing a fragment.
          * 
-         * @param fragmentString
+         * @param fragmentString the fragment
          * @return the path
          */
         public static JsonNodePath of(String fragmentString) {

src/main/java/com/networknt/schema/SpecVersionDetector.java

@@ -68,6 +68,7 @@ public static VersionFlag detect(JsonNode jsonNode) {
      * Optional} value, otherwise - returns the detected spec version wrapped into {@link Optional}.
      *
      * @param jsonNode JSON Node to read from
+     * @param throwIfUnsupported whether to throw an exception if the version is not supported
      * @return Spec version if present, otherwise empty
      */
     public static Optional<VersionFlag> detectOptionalVersion(JsonNode jsonNode, boolean throwIfUnsupported) {

src/main/java/com/networknt/schema/resource/InputStreamSource.java

@@ -27,7 +27,7 @@ public interface InputStreamSource {
      * Opens a new inputstream to the resource.
      * 
      * @return a new inputstream
-     * @throws IOException
+     * @throws IOException if an I/O error occurs
      */
     InputStream getInputStream() throws IOException;
 }

src/test/java/com/networknt/schema/Issue619Test.java

@@ -154,6 +154,13 @@ public void uriThatPointsToNodeThatDoesNotExistShouldFail_Ref() {
 
     @Test
     public void uriThatPointsToNodeThatDoesNotExistShouldFail_Uri() {
+        // This test failed before adding the 10-millisecond sleep. IllegalStateException is returned with recursive update error. This only happens on my faster desktop
+        // computer during 'maven clean install'. It passes within the IDE on the same computer. It passes on my slower laptop. It passes on Travis CI.
+        try {
+            Thread.sleep(10);
+        } catch (InterruptedException e) {
+            e.printStackTrace();
+        }
         assertThrows(JsonSchemaException.class, () -> factory.getSchema(SchemaLocation.of("resource:schema/issue619.json#/definitions/node-that-does-not-exist")));
     }
 }