feat: non-conflicting fetch instrumentation #554
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current instrumentation patches global fetch which is import timing dependant and can conflict with other downstream patches and instrumentations. By subscribing to diagnostic channels, we are able to run alongside other instrumentations without risk of collisions.
fetch -> GET/POST/...['HEAD', 'GET', 'POST', 'PUT', 'PATCH', 'DELETE']the span will be named_OTHERstartSpaninstead ofwithActiveSpansince the span timing depends on separate messagesBefore:

After:
