Skip to content

Conversation

@raviqqe
Copy link
Contributor

@raviqqe raviqqe commented Nov 17, 2025

This PR adds support for the rumdl language server for Markdown files.

As its MDX support is questionable, the configuration is applied to only pure Markdown files.

@raviqqe raviqqe marked this pull request as ready for review November 17, 2025 01:30
@barbedo
Copy link

barbedo commented Dec 5, 2025

I'm getting duplicated diagnostics when using this configuration. It seems that rumdl supports both publishDiagnostics and diagnostics.

I don't know if there is a way to tell rumdl to avoid pushing diagnostics, but I silenced it by stubbing the publishDiagnostics handler:

handlers = {
  ["textDocument/publishDiagnostics"] = function() end,
},

@raviqqe
Copy link
Contributor Author

raviqqe commented Dec 5, 2025

#4199 (comment)

Does anyone know if this is the editor's responsibility to make the diagnostic items unique, or servers should not mix them up? I couldn't find any mention in the LSP documentation...

@barbedo
Copy link

barbedo commented Dec 5, 2025

I also can't find anything explicit in the specifications, which implies that both pushing and pulling should be supported independently by the client.

From the discussion in microsoft/language-server-protocol#1743, it seems that the original intent was to specify that the server pushing diagnostics is not needed if the client communicates that it supports pulling them, but that someone forgot to clarify this in the specs.

@justinmk
Copy link
Member

justinmk commented Dec 5, 2025

Can improve it, meanwhile it sounds like people are using this so we can merge it.

@justinmk justinmk merged commit f944a82 into neovim:master Dec 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants