feat: Make streamrip Termux compatible and fix bugs #919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces several changes to make streamrip compatible with Termux and to fix several bugs. - Replaced platform-specific dependencies `simple-term-menu` and `pick` with `python-cli-menu` to ensure cross-platform compatibility. - Replaced `pycryptodomex` with `pycryptodome` to avoid compilation issues on Termux, and then reverted back to `pycryptodomex` to resolve a dependency conflict with `yt-dlp`. - Improved `youtube-dl` integration by replacing it with `yt-dlp` and using it as a fallback for last.fm playlists. - Fixed file path handling by using `pathlib.Path` more consistently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces several changes to make streamrip compatible with Termux and to fix several bugs.
simple-term-menuandpickwithpython-cli-menuto ensure cross-platform compatibility.pycryptodomexwithpycryptodometo avoid compilation issues on Termux, and then reverted back topycryptodomexto resolve a dependency conflict withyt-dlp.youtube-dlintegration by replacing it withyt-dlpand using it as a fallback for last.fm playlists.pathlib.Pathmore consistently.