Arduino_core_STM32 support (improved) #1571
Conversation
|
@dirkju Thank you for this PR. Please see my review comments that need some attention. |
hal/architecture/STM32/MyHwSTM32.cpp
Outdated
| #ifdef IWDG | ||
| // Reset independent watchdog if enabled | ||
| // Note: Watchdog must be configured separately in sketch if needed | ||
| #if defined(HAL_IWDG_MODULE_ENABLED) | ||
| // Using STM32 HAL | ||
| // Implementation depends on whether user has initialized IWDG | ||
| // For safety, we only reset if it's running | ||
| #endif | ||
| #endif | ||
| // No-op if watchdog not enabled - safer default |
There was a problem hiding this comment.
Here some code is missing to actually reset the wdt if enabled
| // Read internal voltage reference to calculate VDD | ||
| // VREFINT is typically 1.2V (varies by STM32 family) | ||
|
|
||
| uint32_t vrefint = analogRead(AVREF); |
There was a problem hiding this comment.
AVREF is accessed without checking the VREF_AVAILABLE flag, see above in hwRandomNumberInit()
| // Read internal temperature sensor | ||
| // Note: Requires calibration values for accurate results | ||
|
|
||
| int32_t temp_raw = analogRead(ATEMP); |
There was a problem hiding this comment.
ATEMP is accessed without checking the TEMP_SENSOR_AVAILABLE flag
| * STM32duino core provides main() function and serialEvent() handlers. | ||
| * No additional implementation needed - the framework handles setup()/loop() calls. | ||
| */ | ||
|
|
||
| // Note: STM32duino core already provides weak serialEvent handlers | ||
| // We don't need to redefine them here |
There was a problem hiding this comment.
Hook to _begin() and _process() is missing, see other HAL implementation for reference
@tekka007 Completely agree, this is my goal. I was not sure though, if we should do that in a single step. Wdyt - should we try to get out the 2.4.0 release with both STM32 and /F1 and thereafter produce a 2.5 with STM32F1 removed? |
2 participants
Adding Arduino_core_STM32 support
Three previous attempts of adding STM32 support were abandoned (#1422, #1437, #1486).
@tekka007 s branch also served as inspiration. Thanks to everyone of you.
I'm asking you to please consider my attempt :-) @tekka007 @mfalkvidd
Risks
The change is rather local in hal/STM32 and should not cause problems with other architectures.
I've kept the existing legacy hal/STM32F1 unchanged and the respective constant is checked in MySensors.h before my STM32 addition. This should maximize backward-compatibility for STM32F1 (blue pill) legacy users.
Implemented in this version
Planned
Build
I developed under VS Code + Platformio on Windows. I test-compiled examples under the Arduino IDE (also Windows).
Testing
I've tested mostly on a generic black pill STM32F401CE (gateway, node using Ra-01 LoRa and nRF24L01+).
I encourage to test on a broader variety of boards.
Final note
The code has mostly been generated using AI. I asked for a comprehensive review of the previously mentioned three abandoned STM32 PRs and a comparison between building on STM32duino vs the original STM32Cube HAL. Both are feasible but the simplicity of the STM32duino solution stood out.