lld-21 started warning about DllMain symbol

[MehdiChinoune]

Description / Steps to reproduce the issue

Link any binary with libintl or libxml2.

I am no expert.
@mstorsjo @jeremyd2019 @mati865

Expected behavior

To not warn

Actual behavior

  ld.lld: warning: C:/msys64/clang64/lib/libintl.dll.a: skipping imported DllMain symbol [importeddllmain]
  NOTE: this might be a mistake when the DLL/library was produced.
  
  ld.lld: warning: C:/msys64/clang64/lib/libxml2.dll.a: skipping imported DllMain symbol [importeddllmain]
  NOTE: this might be a mistake when the DLL/library was produced.

Verification

• I have verified that my MSYS2 is up-to-date before submitting the report (see https://www.msys2.org/docs/updating/)

Windows Version

MINGW64_NT-10.0-26100

MINGW environments affected

• MINGW64
• MINGW32
• UCRT64
• CLANG64
• CLANGARM64

Are you willing to submit a PR?

I can If It's OK to remove it from the mentioned libraries.

[nwellnhof]

Also see #17820.

[mati865]

Without looking into it (based only on the messages), this warning is valid and good. These import libraries should not dllexport DllMain.

[nwellnhof]

Fixed in libxml2 here: https://gitlab.gnome.org/GNOME/libxml2/-/commit/bd2072f8d025e7a37d527b23b84698460c5798bf

[MehdiChinoune]

OK, I will try to backport libxml2 patch and remove DllMain patch from gettext

[MehdiChinoune]

It looks like clang compiler is now broken because of removing DllMain from libxml2!

[mati865]

Is dllmain still present in libxml2 DLL?

[mstorsjo]

I guess it's possible that if libxml2 previously exported DllMain, any other DLL that linked against libxml2 ended up importing DllMain from there, and when libxml2 no longer exports that, those other DLLs fail to load. So they probably need to be recompiled, with a libxml2 that doesn't export DllMain.

[MehdiChinoune]

Is dllmain still present in libxml2 DLL?

What do you mean?, It's no longer exported.