Skip to content

Semantics: QuadMesh isn't a Quad, lets call it something else #31989

@DennisSmolek

Description

@DennisSmolek

Description

In working on Postprocessing I naturally saw the examples using QuadMesh

However...

It's not a Quad.. Its a fullscreen triangle.

I was surprised we were still using one with the nodes as this was something that got swapped out in other Postprocessing Libraries a long time ago. I was going to write a Fullsize Triangle but it turns out thats what this already is.

Its funny because the Geo still calls its a QuadMesh yet has 3 points etc.

Solution

I think (with this ONLY being for the new renderer especially) its ok to break and call this what it is.

Something verbose like FullscreenTriangle or ScreenTriangle or compact like FullTri

Also QuadMesh is confusing because although its typically used for postprocessing etc it could be another name for a Plane, or maybe a version of THREE.Mesh that uses FBX style Quads instead of Tris.

FullscreenTriangle is very clear on what it (actually) is and what its used for.

Alternatives

I think we can easily wrap the existing names around something new so folks that already use it can move off it, but we should throw a depreciation warning in the constructor etc.

Or just go Threejs style and break it lol.

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions