Skip to content

Conversation

@brizental
Copy link

Before submitting your pull request

  • I agree to license my code under the MPL 2.0 license.
  • I rebased my work on top of the main branch.
  • I ran npm test and all tests passed.
  • I added test coverages if relevant.

Description

This is just a suggestion. See screenshot of what the error looks like:

Screenshot 2023-11-17 at 18 56 41

Two things:

  1. That is not a content suggestion. I couldn't come up with something good so I just added a sentiment there for now 🆘
  2. I had no idea how to add new strings. I added something directly in the l10n submodule. Here it is, just for illustration purposes: https://github.com/brizental/multi-account-containers-l10n/pull/1/files

Type of change

  • Bug fix
  • New feature
  • Major change (fix or feature that would cause existing functionality to work differently than in the current version)

Tag issues related to this pull request:

@brizental brizental changed the title Show error message and troubleshooting steps on contextual identitier error Show error message and troubleshooting steps on contextual identities error Nov 17, 2023
@dannycolin dannycolin self-requested a review November 29, 2023 00:48
@dannycolin
Copy link
Collaborator

I had no idea how to add new strings. I added something directly in the l10n submodule. Here it is, just for illustration purposes: https://github.com/brizental/multi-account-containers-l10n/pull/1/files

You can open a PR on the upstream l10n repository and simply mention that it depends on this PR to be merged.

That is not a content suggestion. I couldn't come up with something good so I just added a sentiment there for now 🆘

Looks good to me.


/* ----- Error ---------- */

#on-error {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: I think we could use more obvious like containers-pref-error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants