Arash/ungrouping tabs #931
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Test addressbar bookmarks when history disabled * add .ymal * edit methods * one method instead of two * remove all.ymal and functional.ymal --------- Co-authored-by: Hani Yacoub <[email protected]>
* vs/add test clipboard flip
* Add adaptive hitory removal * Update methods, add test to manifest * Rename confusing selector * Adjust selector * Set failing test unstable
* Add open link in new container tab test * Improve test * Add selector info * Fix error * update selector
…-desktop-qa-automation into arash/ungrouping-tabs
Collaborator
|
Great first PR, this is really good work, and very well thought out. I appreciate that you commented your code, and that it's well organized and clear. So there are some additional things here:
|
ben-c-at-moz
requested changes
Dec 5, 2025
Collaborator
ben-c-at-moz
left a comment
ben-c-at-moz
left a comment
There was a problem hiding this comment.
Great first PR, work on these fixes and re-request and we can move forward from there. Thanks!
* clean up manifest/addtests * fix githook * attempt to force failure on bad linting * use correct linter * test lint again * test lint again * now test lint passes * don't require future tests for chooser * mark zip type unstable
Co-authored-by: Hani Yacoub <[email protected]>
Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.5.0 to 2.6.0. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@2.5.0...2.6.0) --- updated-dependencies: - dependency-name: urllib3 dependency-version: 2.6.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…-qa-automation into arash/ungrouping-tabs
Collaborator
Author
|
Discussion continues in #939 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Links
Bugzilla: 1993319
TestRail: 2796550
Description of Code / Doc Changes
Process Changes Required
Mark the relevant boxes:
pipenv install)Screenshots or Explanations
Creating tab group was originally a fixture, later it was changed to a function in TabBar class (in browser_object_tabbar.py).
Comments or Future Work
N/A
Workflow Checklist
Thank you!