Implemented Context Manager for Requests

Author: hcwong

agithub/base.py

@@ -188,16 +188,15 @@ def request(self, method, url, bodyData, headers):
             if 'content-type' in headers:
                 del headers['content-type']
 
-        #TODO: Context manager
-        requestBody = RequestBody(bodyData, headers)
-        conn = self.get_connection()
-        conn.request(method, url, requestBody.process(), headers)
-        response = conn.getresponse()
-        status = response.status
-        content = ResponseBody(response)
-        self.headers = response.getheaders()
-
-        conn.close()
+        # Context manager to handle requests
+        with connectionManager(self) as conn:
+            requestBody = RequestBody(bodyData, headers)
+            conn.request(method, url, requestBody.process(), headers)
+            response = conn.getresponse()
+            status = response.status
+            content = ResponseBody(response)
+            self.headers = response.getheaders()
+
         return status, content.processBody()
 
     def _fix_headers(self, headers):
@@ -411,3 +410,19 @@ def _filterEmptyHeaders(self, headers):
                 newHeaders[header] = headers[header]
 
         return newHeaders
+
+class connectionManager(object):
+    '''
+    Context manager for handling connections in client.request
+    '''
+    def __init__(self, client):
+        self.conn = client.get_connection()
+
+    def __enter__(self):
+        return self.conn
+    
+    def __exit__(self, exc_type, exc_value, traceback): 
+        self.conn.close()
+
+
+