refactor(schemes): type execute_function with ExecuteFunction protocol#51
Open
dlyongemallo wants to merge 1 commit into
Open
refactor(schemes): type execute_function with ExecuteFunction protocol#51dlyongemallo wants to merge 1 commit into
execute_function with ExecuteFunction protocol#51dlyongemallo wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors scheme decode() APIs to use a shared ExecuteFunction protocol for the execute_function callback, and updates the default execution utilities to accept extra keyword arguments for decoder compatibility.
Changes:
- Introduces
utils.ExecuteFunction(Protocol) to standardize typing for execution backends passed into scheme decoders. - Updates scheme decoders (
qsm,qpam,sqpam,mqsm,msqpam) to typeexecute_functionasutils.ExecuteFunction(and cleans up unused typing imports). - Updates
utils.executeandutils.execute_with_samplerto accept**kwargs(ignored) to remain compatible with forwarded decoder kwargs.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
quantumaudio/utils/execute.py |
Adds ExecuteFunction protocol; makes execution helpers accept **kwargs for decoder forwarding compatibility. |
quantumaudio/schemes/sqpam.py |
Types execute_function as utils.ExecuteFunction; removes unused typing imports. |
quantumaudio/schemes/qsm.py |
Types execute_function as utils.ExecuteFunction; removes unused typing imports. |
quantumaudio/schemes/qpam.py |
Types execute_function as utils.ExecuteFunction; removes unused typing imports. |
quantumaudio/schemes/msqpam.py |
Types execute_function as utils.ExecuteFunction; corrects keep_padding tuple element types to bool. |
quantumaudio/schemes/mqsm.py |
Types execute_function as utils.ExecuteFunction; corrects keep_padding tuple element types to bool. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.