Saving/refreshing model doesn't reset `Model::$unset`

[mwnciau]

• Laravel-mongodb Version: 4.0.2
• PHP Version: 8.1.19
• Database Driver & Version: mongo 5.0

Description:

Steps to reproduce

Two reproductions:

1. Create/load model $model
2. Call $model->unset('field')
3. Call $model->refresh()
4. $model->field will always be null

And secondly:

1. Create/load model $model
2. Call $model->unset('field')
3. (optional) call $model->save()
4. Accessing $model->field will never call $model->getFieldAttribute() and will always return null.

(In the latter case, our $model->getFieldAttribute() would return an empty array if the value doesn't exist)

Expected behaviour

The Model::$unset array should be cleared on a save/refresh, and it shouldn't prevent getters from being called.

Actual behaviour

Model::$unset persists until the value is set manually, preventing any getXAttribute() getters from being called and always returning null.

[GromNaN]

Hello @mwnciau, thanks for reporting this issue.
This feature was implemented in #2578

Do you want to create a patch to solve this issue on the branch 4.0?

Tracked in PHPORM-133

[mwnciau]

Hi @GromNaN, I believe #2578 was released in 4.0, and this is a bug with the behaviour. Once unset() is called for a field, it will bypass any getFieldAttribute() getters, and refresh() won't remove this unset state so it will always return null.

Edit: Just to note - we're only still on 4.0 because of #2703

[richardfila]

@mwnciau WIP on a fix
#2709