Enable mypy 'check_untyped_defs'

This uncovers various issues with the implementation of `get_resource_class()`.
Now we have mypy passing and the code should work in theory, but the only place
where this method is used (in `ObjectList`), already shows clearly that the
current approach won't work.

We need to rethink the way ObjectList works, and hopefully get rid of
`get_resource_class()` entirely.

Author: Tom Hendrikx

mollie/api/objects/base.py

@@ -1,5 +1,10 @@
+from typing import TYPE_CHECKING, Any
+
 from ..error import EmbedNotFound
 
+if TYPE_CHECKING:
+    from ..client import Client
+
 
 class ObjectBase(dict):
     def __init__(self, data, client):
@@ -42,5 +47,5 @@ def get_object_name(cls):
         return f"{name}s"
 
     @classmethod
-    def get_resource_class(cls, client):
+    def get_resource_class(cls, client: "Client", **kwargs: Any) -> Any:
         raise NotImplementedError  # pragma: no cover

mollie/api/objects/capture.py

@@ -1,12 +1,19 @@
+from typing import TYPE_CHECKING, Any
+
 from .base import ObjectBase
 
+if TYPE_CHECKING:
+    from ..client import Client
+    from ..resources import PaymentCaptures
+
 
 class Capture(ObjectBase):
     @classmethod
-    def get_resource_class(cls, client):
+    def get_resource_class(cls, client: "Client", **kwargs: Any) -> "PaymentCaptures":
         from ..resources import PaymentCaptures
 
-        return PaymentCaptures(client)
+        payment = kwargs["payment"]
+        return PaymentCaptures(client, payment)
 
     @property
     def id(self):
@@ -50,9 +57,10 @@ def get_shipment(self):
         url = self._get_link("shipment")
         if url:
             from ..resources import OrderShipments
+            from .order import Order
 
-            # We fake the order object here, since it is not used by from_url()
-            return OrderShipments(self.client, order=None).from_url(url)
+            order = Order({}, self.client)
+            return OrderShipments(self.client, order).from_url(url)
 
     def get_settlement(self):
         """Return the settlement for this capture."""

mollie/api/objects/mandate.py

@@ -1,12 +1,19 @@
+from typing import TYPE_CHECKING, Any
+
 from .base import ObjectBase
 
+if TYPE_CHECKING:
+    from ..client import Client
+    from ..resources import CustomerMandates
+
 
 class Mandate(ObjectBase):
     @classmethod
-    def get_resource_class(cls, client):
+    def get_resource_class(cls, client: "Client", **kwargs: Any) -> "CustomerMandates":
         from ..resources import CustomerMandates
 
-        return CustomerMandates(client)
+        customer = kwargs["customer"]
+        return CustomerMandates(client, customer)
 
     STATUS_PENDING = "pending"
     STATUS_VALID = "valid"

mollie/api/objects/order_line.py

@@ -1,12 +1,19 @@
+from typing import TYPE_CHECKING, Any
+
 from .base import ObjectBase
 
+if TYPE_CHECKING:
+    from ..client import Client
+    from ..resources import OrderLines
+
 
 class OrderLine(ObjectBase):
     @classmethod
-    def get_resource_class(cls, client):
+    def get_resource_class(cls, client: "Client", **kwargs: Any) -> "OrderLines":
         from ..resources import OrderLines
 
-        return OrderLines(client)
+        order = kwargs["order"]
+        return OrderLines(client, order)
 
     STATUS_CREATED = "created"
     STATUS_AUTHORIZED = "authorized"

mollie/api/objects/payment.py

@@ -213,7 +213,8 @@ def get_subscription(self):
         if url:
             from ..resources import CustomerSubscriptions
 
-            return CustomerSubscriptions(self.client, customer=None).from_url(url)
+            customer = Customer({}, self.client)
+            return CustomerSubscriptions(self.client, customer).from_url(url)
 
     def get_customer(self):
         """Return the customer for this payment."""

mollie/api/objects/subscription.py

@@ -6,10 +6,11 @@
 
 class Subscription(ObjectBase):
     @classmethod
-    def get_resource_class(cls, client):
+    def get_resource_class(cls, client, **kwargs):
         from ..resources import CustomerSubscriptions
 
-        return CustomerSubscriptions(client)
+        customer = kwargs["customer"]
+        return CustomerSubscriptions(client, customer)
 
     STATUS_ACTIVE = "active"
     STATUS_PENDING = "pending"  # Waiting for a valid mandate.

mypy.ini

@@ -6,6 +6,7 @@ no_implicit_optional = True
 strict_equality = True
 strict_concatenate = True
 disallow_incomplete_defs = True
+check_untyped_defs = True
 
 [mypy-requests_oauthlib.*]
 # requests-oauthlib-1.3.1 has no types yet, but: https://github.com/requests/requests-oauthlib/issues/428