Disallow Carbon\Carbon::create()

Author: spawnia

rector.php

@@ -24,8 +24,8 @@
         Rector\PHPUnit\CodeQuality\Rector\Class_\PreferPHPUnitSelfCallRector::class,
     ])
     ->withSkip([
+        Rector\PHPUnit\CodeQuality\Rector\MethodCall\AssertCountWithZeroToAssertEmptyRector::class, // sloppy
         Rector\PHPUnit\CodeQuality\Rector\Class_\PreferPHPUnitThisCallRector::class, // breaks tests
-        Rector\PHPUnit\CodeQuality\Rector\Class_\RemoveDataProviderParamKeysRector::class, // breaks tests
         Rector\CodeQuality\Rector\Concat\JoinStringConcatRector::class => [
             __DIR__ . '/tests/CSVArrayTest.php', // keep `\r\n` for readability
         ],

rules.neon

@@ -3,10 +3,16 @@ rules:
 #- MLL\Utils\PHPStan\Rules\ThrowableClassNameRule
 #- MLL\Utils\PHPStan\Rules\VariableNameIdToIDRule
 parameters:
+  # https://github.com/spaze/phpstan-disallowed-calls/blob/main/docs/custom-rules.md
   disallowedFunctionCalls:
   - function: 'compact()'
-    message: 'makes refactoring code hard'
-    errorTip: 'use standard array syntax instead'
+    message: 'makes refactoring code hard.'
+    errorTip: 'use standard array syntax instead.'
   # https://github.com/itsgoingd/clockwork?tab=readme-ov-file#logging
   - function: 'clock()'
-    message: 'remove debugging code'
+    message: 'it is just meant for debugging.'
+    errorTip: 'remove debugging code.'
+  disallowedStaticCalls:
+  - method: 'Carbon\Carbon::create()'
+    message: 'it ignores errors.'
+    errorTip: 'use Carbon\Carbon::createStrict() instead.'