Skip to content

Commit de61ef3

Browse files
Quick fixes: accuracy mode & C API
1 parent 2664da2 commit de61ef3

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

loadgen/bindings/c_api.cc

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ limitations under the License.
1313
#include "c_api.h"
1414

1515
#include <string>
16+
#include <cassert>
1617

1718
#include "../loadgen.h"
1819
#include "../query_sample.h"
@@ -148,7 +149,7 @@ class GroupedQuerySampleLibraryTrampoline : public QuerySampleLibrary {
148149

149150
total_sample_count_ = 0;
150151

151-
for(ssize_t i = 0; i < group_sizes.size(); i++){
152+
for(size_t i = 0; i < group_sizes.size(); i++){
152153
group_sizes_.push_back(group_sizes[i]);
153154
total_sample_count_ += group_sizes[i];
154155
for(size_t j = 0; j < group_sizes[i]; j++){
@@ -193,7 +194,7 @@ void* ConstructGroupedQSL(ClientData client_data, const char* name, size_t name_
193194
UnloadSamplesFromRamCallback unload_samples_from_ram_cb,
194195
std::vector<size_t>& group_sizes) {
195196
GroupedQuerySampleLibraryTrampoline* qsl = new GroupedQuerySampleLibraryTrampoline(
196-
client_data, std::string(name, name_length), total_sample_count,
197+
client_data, std::string(name, name_length),
197198
performance_sample_count, load_samples_to_ram_cb,
198199
unload_samples_from_ram_cb, group_sizes);
199200
return reinterpret_cast<void*>(qsl);

loadgen/loadgen.cc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,6 @@ std::vector<QueryMetadata> GenerateQueries(
318318
auto sample_distribution_equal_issue = SampleDistributionEqualIssue(
319319
min_queries, loaded_samples.size(), &sample_rng);
320320

321-
TestScenario temp_scenario = scenario;
322321
auto schedule_distribution = ScheduleDistribution<scenario>(settings.target_qps);
323322
auto schedule_constant_distribution = ScheduleConstantDistribution(settings.target_qps);
324323

@@ -751,7 +750,7 @@ std::vector<LoadableSampleSet> GenerateLoadableSets(
751750
size_t number_of_groups = qsl->NumberOfGroups();
752751
for (size_t i = 0; i < number_of_groups; i++) {
753752
size_t group_size = qsl->GroupSize(groupIdx[idx]);
754-
if (loadable_set.size() + group_size < set_size) {
753+
if (loadable_set.size() + group_size <= set_size) {
755754
for (size_t j = 0; j < group_size; j++) {
756755
loadable_set.push_back(samples[idx]);
757756
idx++;

0 commit comments

Comments
 (0)