fix(gitlab): request project license from the API (#6724)

* fix(gitlab): request project license from the API

The GitLab API omits license information from the project payload
unless license=true is passed as a query parameter, so the
gitlab/license property was always empty. Request it explicitly
when fetching a project.

Fixes #6589

Signed-off-by: Yash Jain <23dec512@lnmiit.ac.in>

* chore: retrigger CI after transient module proxy failure

Signed-off-by: Yash Jain <23dec512@lnmiit.ac.in>

---------

Signed-off-by: Yash Jain <23dec512@lnmiit.ac.in>

Author: YAshhh29

internal/providers/gitlab/properties_test.go

@@ -8,6 +8,7 @@ import (
 	"encoding/json"
 	"net/http"
 	"net/http/httptest"
+	"net/url"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -388,6 +389,45 @@ func TestPropertiesToProtoMessage(t *testing.T) {
 	}
 }
 
+func Test_gitlabClient_getGitLabProject_requestsLicense(t *testing.T) {
+	t.Parallel()
+
+	var gotQuery url.Values
+	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		gotQuery = r.URL.Query()
+
+		resp := &gitlab.Project{
+			ID:   1,
+			Name: "project-1",
+			Namespace: &gitlab.ProjectNamespace{
+				Path: "group",
+			},
+			License: &gitlab.ProjectLicense{
+				Key:  "mit",
+				Name: "MIT License",
+			},
+		}
+
+		w.Header().Set("Content-Type", "application/json")
+		w.WriteHeader(http.StatusOK)
+		//nolint:gosec // This is a test
+		json.NewEncoder(w).Encode(resp)
+	}))
+	defer ts.Close()
+
+	got, err := newTestGitlabProvider(ts.URL).getPropertiesForRepo(
+		context.Background(),
+		properties.NewProperties(map[string]any{
+			properties.PropertyUpstreamID: "1",
+		}),
+	)
+	assert.NoError(t, err)
+
+	assert.Equal(t, "true", gotQuery.Get("license"),
+		"GitLab omits license information unless license=true is requested")
+	assert.Equal(t, "MIT License", got.GetProperty(RepoPropertyLicense).GetString())
+}
+
 func newTestGitlabProvider(endpoint string) *gitlabClient {
 	return &gitlabClient{
 		cred: &credentials.GitLabTokenCredential{},

internal/providers/gitlab/repository_properties.go

@@ -54,6 +54,9 @@ func (c *gitlabClient) getGitLabProject(
 		return nil, fmt.Errorf("failed to join URL path for project using upstream ID: %w", err)
 	}
 
+	// GitLab only includes the project's license in the response when explicitly asked for it
+	projectURLPath += "?" + url.Values{"license": []string{"true"}}.Encode()
+
 	// NOTE: We're not using github.com/xanzy/go-gitlab to do the actual
 	// request here because of the way they form authentication for requests.
 	// It would be ideal to use it, so we should consider contributing and making