GDK-1702: CI cost — staticcheck skips Go-free pushes, e2e shards balance by measured weight, five browser specs move to vitest

Staticcheck runs only when a push touches Go, go.mod/go.sum, the script
or the workflow (fail-open: a filter error runs it). tools/e2e-partition.sh
partitions e2e specs into N bins by longest-processing-time over
e2e/shard-weights.tsv (measured seconds) instead of file order, and
--check keeps the weights file honest against the spec list. Assertions
that need no browser (menu loading, settings copy, palette entry,
activity visibility, mirror-status wording) leave Playwright for vitest.
Audit axis 9 of the v0.22 release audit (GDK-1698).

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

Author: midagedev

.github/workflows/ci.yml

@@ -273,7 +273,56 @@ jobs:
     steps:
       - uses: actions/checkout@v4
 
+      # GDK-1702: this job billed ~5 min of setup+install per push while
+      # the census measured most pushes touching no Go at all. It is a gate
+      # (the cross-platform list is empty since 90e27bdf), so the skip must
+      # never hide a Go change — hence the fail-open rules below. GitHub Actions has no
+      # per-job paths filter (`on:` filters are workflow-level and would
+      # skip every job), so the first step diffs the change and every step
+      # below is gated on its output.
+      #
+      # It fails OPEN, and that is the contract: a forced push whose before
+      # is unreachable, a first push (all-zero before), workflow_dispatch,
+      # an empty event base, or any diff error runs the job. A gate skipped
+      # by mistake is the failure mode that matters; a gate run for nothing
+      # is five minutes.
+      #
+      # The path list is the Go surface plus the job's own inputs: the
+      # script it runs, and this workflow (a change here can rewrite the
+      # gate itself). `git diff A B` compares trees without needing shared
+      # history, so two depth-1 objects are enough.
+      - name: Did this change touch Go?
+        id: gofilter
+        env:
+          EVENT_NAME: ${{ github.event_name }}
+          BEFORE: ${{ github.event.before }}
+          BASE_SHA: ${{ github.event.pull_request.base.sha }}
+          SHA: ${{ github.sha }}
+        run: |
+          run_job() { echo "go=true" >> "$GITHUB_OUTPUT"; echo "staticcheck: $1"; exit 0; }
+          skip_job() { echo "go=false" >> "$GITHUB_OUTPUT"; echo "staticcheck: $1"; exit 0; }
+          case "$EVENT_NAME" in
+            pull_request) base="$BASE_SHA" ;;
+            push) base="$BEFORE" ;;
+            *) run_job "event '$EVENT_NAME' has no before — running (fail open)" ;;
+          esac
+          if [ -z "$base" ] || printf '%s' "$base" | grep -Eq '^0+$'; then
+            run_job "no usable base sha (first push or forced push) — running (fail open)"
+          fi
+          if ! git fetch --no-tags --depth=1 origin "$base" 2>/dev/null; then
+            run_job "base $base not fetchable — running (fail open)"
+          fi
+          if ! changed="$(git diff --name-only "$base" "$SHA")"; then
+            run_job "git diff failed — running (fail open)"
+          fi
+          n=$(printf '%s\n' "$changed" | grep -c . || true)
+          if printf '%s\n' "$changed" | grep -Eq '\.go$|^go\.mod$|^go\.sum$|^desktop/|^tools/staticcheck\.sh$|^\.github/workflows/ci\.yml$'; then
+            run_job "Go-touching change in ${n} changed path(s)"
+          fi
+          skip_job "no Go-touching change in ${n} changed path(s)"
+
       - name: Set up Go
+        if: steps.gofilter.outputs.go == 'true'
         uses: actions/setup-go@v5
         with:
           go-version-file: go.mod
@@ -283,11 +332,13 @@ jobs:
       # artefact is the script's classifier, not staticcheck. It runs over
       # fixtures, needs no toolchain, and takes a second.
       - name: staticcheck.sh self-test
+        if: steps.gofilter.outputs.go == 'true'
         run: bash tools/staticcheck.sh --self-test
 
       # Pinned on purpose: staticcheck gains checks between releases, and
       # @latest would turn a new check into a CI change nobody made.
       - name: Install staticcheck
+        if: steps.gofilter.outputs.go == 'true'
         run: |
           go install honnef.co/go/tools/cmd/staticcheck@v0.7.0
           echo "$(go env GOPATH)/bin" >> "$GITHUB_PATH"
@@ -301,6 +352,7 @@ jobs:
       # second copy of the mirror-flaky apt step in this file for a job that
       # cannot fail. The root module gets all three either way.
       - name: staticcheck over the GOOS matrix
+        if: steps.gofilter.outputs.go == 'true'
         run: bash tools/staticcheck.sh
 
   e2e:
@@ -312,6 +364,15 @@ jobs:
     # seeded home, so e2e/playwright.config.ts keeps workers: 1 and
     # fullyParallel: false — raising workers inside one runner is the
     # unsafe variant (single shared served instance) and stays out.
+    #
+    # GDK-1702: which files land on which shard is owned by
+    # tools/e2e-partition.sh — dealt by the measured table
+    # (e2e/shard-weights.tsv), because --shard's count-based split sent
+    # 220/297/261 s of test time to the three runners and the longest
+    # shard is the job's wall clock. --check runs in every shard before
+    # the run: a spec that escaped the deal (new file outside the table,
+    # stale weight row, glob drifting from what playwright collects)
+    # fails the job that would otherwise have skipped it silently.
     strategy:
       fail-fast: false
       matrix:
@@ -478,8 +539,14 @@ jobs:
           echo "::error::playwright chromium download failed three times — browser cache, not apt, not the tests"
           exit 1
 
+      # Positional e2e/-prefixed paths on purpose: --shard=N/3 splits by
+      # count (balanced only if every file costs the same), while the
+      # partitioner deals files by measured seconds.
+      - name: E2E partition check
+        run: bash tools/e2e-partition.sh --check 3
+
       - name: Run browser E2E
-        run: npx playwright test --config e2e/playwright.config.ts --shard=${{ matrix.shard }}/3
+        run: npx playwright test --config e2e/playwright.config.ts $(bash tools/e2e-partition.sh ${{ matrix.shard }} 3)
 
   # Nested module (desktop/go.mod). package main imports wails v3, which does
   # not compile on Linux with CGO_ENABLED=0 (undefined pointer in the linux

e2e/docs-ux.spec.ts

@@ -835,6 +835,14 @@ test.describe('docs empty states', () => {
  * ("Fetching documents") — at the same moment, about the same pass. Read
  * together, issue sync and document sync looked like two systems. These pin
  * that every surface renders the same string, and that the count is in it.
+ *
+ * The issues-pass wording and the announce threshold moved to vitest by the
+ * GDK-1702 cost ladder: the sentence is web/src/lib/mirror-status.test.ts
+ * (busyLabel's issues branch, the 4-digit comma, and the GDK-460 scans of
+ * which surface may render it), and the elapsed-time rule is
+ * web/src/stores/issues-activity-visibility.test.ts (ACTIVITY_MIN_VISIBLE_MS
+ * and the `a.running && old` gate). The browser keeps the running half —
+ * the document pass below crosses chip, CTA and sidebar end to end.
  */
 test.describe('sync status is one sentence', () => {
   const API = apiURL('/api/v1/issues/')
@@ -890,35 +898,6 @@ test.describe('sync status is one sentence', () => {
     await expect(page.getByTestId('sidebar-sync-now')).toContainText('Sync log')
     await expect(page.getByTestId('sidebar-sync-now')).not.toContainText(expected)
   })
-
-  test('an issue pass says issues, not documents', async ({ page }) => {
-    await activity(page, { running: true, source: 'issues', fetched: 6932 })
-    await gotoApp(page)
-
-    // GDK-460: busy wording is the chip's. The sidebar keeps its own name.
-    await expect(page.getByTestId('freshness-chip')).toContainText('Syncing issues · 6,932', {
-      timeout: 20_000,
-    })
-    await expect(page.getByTestId('sidebar-sync-now')).toContainText('Sync log')
-    await expect(page.getByTestId('sidebar-sync-now')).not.toContainText('Syncing issues')
-  })
-
-  test('a pass is announced only once it has run long enough to wonder about', async ({ page }) => {
-    // The watch loop finishes an incremental in a second or two, every minute.
-    // Narrating those would put a blinking status in front of someone all day;
-    // the six-minute backfill is what needed saying. So the rule is elapsed
-    // time, and this asserts both halves of it rather than the quiet first
-    // instant, which would pass with no rule at all.
-    await activity(page, { running: true, source: 'issues', fetched: 2 }, 500)
-    await gotoApp(page)
-
-    const chip = page.getByTestId('freshness-chip')
-    await page.waitForTimeout(1_500) // two polls in, still young
-    await expect(chip).not.toContainText('Syncing')
-    // Same stubbed pass, now old enough: the wording appears without anything
-    // else changing, which is the threshold and not a coincidence of timing.
-    await expect(chip).toContainText('Syncing issues', { timeout: 15_000 })
-  })
 })
 
 test.describe('sync status at rest', () => {

e2e/menu-loading.spec.ts

@@ -20,6 +20,13 @@ import { MENU_ORIGIN_TIMEOUT_MS } from '../web/src/lib/menu-loading'
  *    note) when one exists, otherwise the catalog's failure sentence and a
  *    Retry.
  *
+ * The detail-picker half of the contract moved to vitest (GDK-1702 cost
+ * ladder): withMenuTimeout's timing and the picker's cached-catalog
+ * fallback are web/src/lib/menu-loading.test.ts — the fallback is pinned
+ * as a source scan there, because the picker cannot mount in the unit
+ * project and the fallback's claims are its source. This spec keeps the
+ * real path: one menu opened against a stalled origin, end to end.
+ *
  * The stalled routes fulfill after 60 s — far past every assertion — so the
  * pre-fix tree hangs exactly like the unreachable origin did, and the
  * post-fix fallback state stays put for the assertions (no late-arriving
@@ -94,63 +101,4 @@ test.describe('menu origin wait is capped (GDK-1566)', () => {
 
     expect(appConsoleErrors(errors), `console errors:\n${errors.join('\n')}`).toEqual([])
   })
-
-  test('detail priority picker: timeout falls back to the site catalog with the offline note', async ({
-    page,
-  }) => {
-    const errors = attachConsoleErrors(page)
-    // Prime the site catalog first: the bulk menu loads it instantly.
-    await page.route('**/api/v1/issues/priorities/', async (route) => {
-      if (route.request().method() !== 'GET') return route.continue()
-      await route.fulfill({
-        status: 200,
-        contentType: 'application/json',
-        json: { priorities: [{ id: '1', name: 'Highest' }, { id: '3', name: 'Medium' }] },
-      })
-    })
-    await gotoApp(page)
-    await selectBulkRows(page, 1)
-
-    await page.getByRole('button', { name: en['bulk.changePriority'], exact: true }).click()
-    const bulkMenu = page.getByTestId('bulk-priority-menu')
-    await expect(bulkMenu.getByText('Highest')).toBeVisible()
-    await page.keyboard.press('Escape')
-    await expect(bulkMenu).toBeHidden()
-    // Clear the bulk selection so the detail panel is the only surface.
-    await page.keyboard.press('Escape')
-    await expect(page.getByTestId('bulk-bar')).toBeHidden()
-
-    // Open the first issue; stall only its per-key catalog.
-    const row = page.locator('[data-testid="issue-list-scroller"] [data-issue-key]').first()
-    const key = await row.getAttribute('data-issue-key')
-    expect(key).toBeTruthy()
-    await page.route(`**/api/v1/issues/${key}/priorities/`, async (route) => {
-      if (route.request().method() !== 'GET') return route.continue()
-      await stall()
-      await route.fulfill({
-        status: 200,
-        contentType: 'application/json',
-        json: { priorities: [{ id: '9', name: 'Per-key Only' }] },
-      })
-    })
-    await row.click()
-    const panel = page.getByTestId('issue-detail-panel')
-    await expect(panel).toHaveClass(/is-open/)
-
-    await page.keyboard.press('p')
-    const menu = page.getByRole('listbox', { name: en['common.priority'] })
-    await expect(menu).toBeVisible()
-    await expect(menu.getByText(en['common.loading'])).toBeVisible()
-
-    await expect(menu.getByText(en['common.loading'])).toBeHidden({
-      timeout: MENU_ORIGIN_TIMEOUT_MS + 4_000,
-    })
-    // The per-key answer never came, so the rows are the cached site catalog
-    // (not "Per-key Only"), and the note says so.
-    await expect(menu.getByText('Highest')).toBeVisible()
-    await expect(menu.getByText('Per-key Only')).toHaveCount(0)
-    await expect(menu.getByTestId('menu-cached-note')).toHaveText(en['app.offlineBanner'])
-
-    expect(appConsoleErrors(errors), `console errors:\n${errors.join('\n')}`).toEqual([])
-  })
 })

e2e/mirror-instant.spec.ts

@@ -22,8 +22,17 @@ import {
  * value moves when and only when the mirror does, WAL included — is pinned in
  * Go (internal/store/version_test.go, internal/server/focus_test.go).
  *
+ * One test, both halves of the contract (GDK-1702 cost ladder merged the
+ * two: each paid a full boot + anchor to drive the same rig, and the
+ * windows combine cleanly):
+ *  - a still mirror must not pull (the control window before the burst);
+ *  - moves reach the pool within INSTANT_MS — not on the backstop;
+ *  - moves inside one 500ms tick coalesce into exactly one pull, and a
+ *    mirror that settles does not pull again (the settle window doubles
+ *    as the still-mirror control on the post-pull state).
+ *
  * FAIL-first: with the client ignoring mirrorVersion, the injected issue
- * appears only on the backstop tick, and this stopped on
+ * appears only on the backstop tick, and this stops on
  * 'the board must pull within 3s of the mirror moving'.
  */
 
@@ -99,7 +108,9 @@ async function installRig(page: Page): Promise<Rig> {
 }
 
 test.describe('GDK-1170 a write elsewhere reaches an open board', () => {
-  test('the board pulls when mirrorVersion moves, not on the 15s backstop', async ({ page }) => {
+  test('the board pulls on a move, within the instant window, exactly once — never on ticks or stacked', async ({
+    page,
+  }) => {
     const errors = attachConsoleErrors(page)
     const rig = await installRig(page)
     await gotoApp(page)
@@ -119,42 +130,33 @@ test.describe('GDK-1170 a write elsewhere reaches an open board', () => {
     await page.waitForTimeout(INSTANT_MS) // duration is the contract: no pull while the mirror sits still
     expect(rig.deltas(), 'a still mirror must not pull a delta on the 500ms tick').toBe(anchored)
 
-    rig.arm()
-    rig.bump()
-
-    // The assertion waits on the state itself: the injected issue is in the
-    // pool, which is only true after a delta landed and was applied.
-    await expect(
-      page.getByText(new RegExp(`${DEMO_ISSUE_COUNT + 1} issues`)).first(),
-      'the board must pull within 3s of the mirror moving',
-    ).toBeVisible({ timeout: INSTANT_MS })
-
-    expect(rig.deltas(), 'exactly one delta for one move').toBe(anchored + 1)
-    expect(appConsoleErrors(errors)).toEqual([])
-  })
-
-  test('a mirror that keeps moving pulls once per move, never stacked', async ({ page }) => {
-    const errors = attachConsoleErrors(page)
-    const rig = await installRig(page)
-    await gotoApp(page)
-    await expect(page.getByText(new RegExp(`${DEMO_ISSUE_COUNT} issues`)).first()).toBeVisible({
-      timeout: 30_000,
-    })
-    await page.waitForResponse((r) => r.url().includes('/delta/'), { timeout: 30_000 })
-    const anchored = rig.deltas()
-
     // Three moves inside one 500ms tick. The tab must not fire three deltas —
-    // a poll that stacks requests is a new defect, not a fixed one.
+    // a poll that stacks requests is a new defect, not a fixed one — and it
+    // must not fire zero either (the pre-fix client ignored the version and
+    // waited for the backstop).
+    rig.arm()
     rig.bump()
     rig.bump()
     rig.bump()
 
     await expect
       .poll(() => rig.deltas(), { timeout: INSTANT_MS })
       .toBeGreaterThan(anchored)
-    // Settle, then count. Still short of the backstop at anchored + 15s.
+
+    // Settle, then count. Still short of the backstop at anchored + 15s:
+    // the burst coalesced into one pull, and a mirror that went still again
+    // does not pull a follow-up — the same still-mirror control, on the
+    // post-pull state.
     await page.waitForTimeout(INSTANT_MS) // duration is the contract: no follow-up pull after the burst settles
     expect(rig.deltas(), 'three moves inside one tick are one pull').toBe(anchored + 1)
+
+    // The assertion waits on the state itself: the injected issue is in the
+    // pool, which is only true after a delta landed and was applied.
+    await expect(
+      page.getByText(new RegExp(`${DEMO_ISSUE_COUNT + 1} issues`)).first(),
+      'the move must reach the pool within 3s',
+    ).toBeVisible({ timeout: INSTANT_MS })
+
     expect(BACKSTOP_MS).toBeGreaterThan(2 * INSTANT_MS)
     expect(appConsoleErrors(errors)).toEqual([])
   })

e2e/palette.spec.ts

@@ -1,6 +1,5 @@
 import { test, expect } from '@playwright/test'
 import { apiURL, attachConsoleErrors, gotoApp, searchInput, DEMO_ISSUE_COUNT_EN_RE } from './helpers'
-import { en } from '../web/src/lib/i18n/en'
 
 test.describe('command palette', () => {
   test('Cmd+K opens it, typing stays local, Enter opens the issue detail', async ({ page }) => {
@@ -445,23 +444,10 @@ test.describe('command palette', () => {
     expect(errors, `console errors:\n${errors.join('\n')}`).toEqual([])
   })
 
-  test('GDK-472: palette entry names its scope; empty palette is one phrase', async ({
-    page,
-  }) => {
-    const errors = attachConsoleErrors(page)
-    await gotoApp(page)
-
-    const entry = page.getByTestId('palette-open')
-    await expect(entry).toContainText('Search everything')
-    await expect(entry.locator('kbd')).toBeVisible()
-
-    await entry.click()
-    const palette = page.getByRole('dialog', { name: 'Command palette' })
-    await expect(palette).toBeVisible()
-    const box = palette.getByRole('combobox')
-    await expect(box).toHaveAttribute('placeholder', en['palette.placeholder'])
-    await expect(palette.getByTestId('palette-empty-hint')).toHaveCount(0)
-
-    expect(errors, `console errors:\n${errors.join('\n')}`).toEqual([])
-  })
+  // GDK-472 (entry names its scope; empty palette is one phrase) moved to
+  // web/src/components/palette/palette-entry.test.ts by the GDK-1702 cost
+  // ladder: every assertion read source or catalog strings, and opening
+  // the palette to read them back cost a boot. Entry click-through — open,
+  // type, Enter — is the real path this spec keeps (above and in
+  // usearch.spec.ts).
 })