feat(serve): open the browser once the server answers, --no-open opts out

scry demo forwards the flag; the e2e fixture passes it so test runs
never spawn browser windows.

Author: midagedev

cmd/scry/agent.go

@@ -486,6 +486,15 @@ func cmdOpen(args []string) error {
 		return errors.New("no Jira site configured — run `scry init` first")
 	}
 	u := strings.TrimRight(cfg.Site, "/") + "/browse/" + url.PathEscape(normalizeKey(args[0]))
+	if err := openBrowser(u); err != nil {
+		return fmt.Errorf("could not open a browser (%v) — the URL is %s", err, u)
+	}
+	fmt.Println(u)
+	return nil
+}
+
+// openBrowser starts the platform's URL opener and does not wait for it.
+func openBrowser(u string) error {
 	var cmd *exec.Cmd
 	switch runtime.GOOS {
 	case "darwin":
@@ -495,9 +504,5 @@ func cmdOpen(args []string) error {
 	default:
 		cmd = exec.Command("xdg-open", u)
 	}
-	if err := cmd.Start(); err != nil {
-		return fmt.Errorf("could not open a browser (%v) — the URL is %s", err, u)
-	}
-	fmt.Println(u)
-	return nil
+	return cmd.Start()
 }

cmd/scry/main.go

@@ -92,6 +92,7 @@ func cmdServe(args []string) error {
 	withSync := fs.Bool("sync", false, "run the incremental sync loop inside the server")
 	importAttachments := fs.String("import-attachments", "",
 		"seed the attachment cache from a directory holding manifest.json (see examples/attachments)")
+	noOpen := fs.Bool("no-open", false, "do not open the browser after the server starts")
 	if err := fs.Parse(args); err != nil {
 		return err
 	}
@@ -207,6 +208,9 @@ func cmdServe(args []string) error {
 	if len(cfg.Projects) == 0 {
 		log.Printf("no projects configured — run `scry init`")
 	}
+	if !*noOpen {
+		go openOnceUp(browseAddr(*addr))
+	}
 	err = srv.ListenAndServe()
 	if err == http.ErrServerClosed {
 		return nil
@@ -574,6 +578,7 @@ func cmdDemo(args []string) error {
 	addr := fs.String("addr", "127.0.0.1:7878", "listen address")
 	static := fs.String("static", "dist/app", "directory holding the built web UI")
 	dbPath := fs.String("db", "examples/demo.db", "snapshot to serve")
+	noOpen := fs.Bool("no-open", false, "do not open the browser after the server starts")
 	if err := fs.Parse(args); err != nil {
 		return err
 	}
@@ -608,7 +613,41 @@ func cmdDemo(args []string) error {
 	}
 	log.Printf("demo mirror in %s (deleted on exit)", home)
 	defer os.RemoveAll(home)
-	return cmdServe([]string{"--addr", *addr, "--static", *static})
+	serveArgs := []string{"--addr", *addr, "--static", *static}
+	if *noOpen {
+		serveArgs = append(serveArgs, "--no-open")
+	}
+	return cmdServe(serveArgs)
+}
+
+// browseAddr turns a listen address into the URL a person should visit:
+// a blank or wildcard host becomes localhost.
+func browseAddr(addr string) string {
+	host, port, err := net.SplitHostPort(addr)
+	if err != nil {
+		return "http://" + addr
+	}
+	if host == "" || host == "0.0.0.0" || host == "::" {
+		host = "localhost"
+	}
+	return "http://" + net.JoinHostPort(host, port)
+}
+
+// openOnceUp opens the browser as soon as the server answers /healthz, so the
+// tab never lands on a connection error. Gives up quietly after ~5s — a browser
+// failing to open must never take the server down with it.
+func openOnceUp(u string) {
+	for i := 0; i < 50; i++ {
+		res, err := http.Get(u + "/healthz")
+		if err == nil {
+			res.Body.Close()
+			if err := openBrowser(u); err != nil {
+				log.Printf("could not open a browser: %v — visit %s", err, u)
+			}
+			return
+		}
+		time.Sleep(100 * time.Millisecond)
+	}
 }
 
 func cmdProfiles() error {

e2e/serve.sh

@@ -90,5 +90,5 @@ echo "[e2e] serving on 127.0.0.1:7877 (SCRY_HOME=$SCRY_HOME)…"
 # The snapshot references attachments whose bytes cannot be proxied (the fixture
 # credential is fake), so seed the cache from the committed images. Without this
 # the browser logs 502s and the console-hygiene spec fails.
-exec "$BIN" serve --addr 127.0.0.1:7877 --static dist/app \
+exec "$BIN" serve --addr 127.0.0.1:7877 --static dist/app --no-open \
   --import-attachments "$ROOT/examples/attachments"