Skip to content

Conversation

@mercyblitz
Copy link
Contributor

@mercyblitz mercyblitz commented Oct 27, 2025

This pull request includes a version bump for both the project and its Spring module releases, as well as improvements to the WebEndpointMapping class to ensure equality checks and JSON serialization include the kind property. Test coverage and documentation are also updated accordingly.

Version updates:

  • Updated project version to 0.1.4-SNAPSHOT in pom.xml and Spring module latest versions to 0.1.4 and 0.2.4 in README.md. [1] [2]

WebEndpointMapping improvements:

  • Modified equals() in WebEndpointMapping to include the kind property in equality checks, ensuring more accurate comparisons between mappings.
  • Updated toJSON() and related helper methods in WebEndpointMapping to serialize the kind property, and updated a test JSON resource to reflect this change. [1] [2] [3]

Testing and documentation:

  • Enhanced WebEndpointMappingTest to verify that mappings with different kind values are not considered equal.
  • Minor JavaDoc formatting fix in BeanPropertyChangedEvent.

Changed the Javadoc heading from 'Example usage:' to 'Example Usage' in BeanPropertyChangedEvent.java for consistency with documentation style.
Updated all Javadoc and code references from javax.servlet to jakarta.servlet to align with the latest Servlet API package. Also fixed equals() to compare kind and added kind to JSON output for improved serialization.
Introduced a new 'kind' field with value 'CUSTOMIZED' in the web-mapping-descriptor.json for test resources. This may be used to distinguish mapping types in tests.
Updated the <revision> property in pom.xml to prepare for the next development iteration.
Bump the documented latest version of the 0.1.x branch from 0.1.3 to 0.1.4 to reflect the most recent release.
@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ Complexity Δ
...spring/context/event/BeanPropertyChangedEvent.java 100.00% <ø> (ø) 6.00 <0.00> (ø)
...sphere/spring/web/metadata/WebEndpointMapping.java 100.00% <100.00%> (ø) 54.00 <1.00> (+2.00)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Updated all Javadoc references from jakarta.servlet to javax.servlet to ensure compatibility with environments using javax.servlet APIs. No functional code changes were made.
Added an assertion to verify that WebEndpointMapping objects with different kinds are not equal. This improves test coverage for the equals method.
@sonarqubecloud
Copy link

@mercyblitz mercyblitz merged commit a235d90 into microsphere-projects:dev-1.x Oct 27, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant