Skip to content

Commit 3fb2679

Browse files
committed
clean up useless code
1 parent 4fb2c28 commit 3fb2679

File tree

4 files changed

+4
-33
lines changed

4 files changed

+4
-33
lines changed

jdtls.ext/com.microsoft.jdtls.ext.core/plugin.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@
1212
<command id="java.project.checkImportStatus" />
1313
<command id="java.project.getImportClassContent" />
1414
<command id="java.project.getDependencies" />
15-
<command id="java.project.getImportClassContentWithResult" />
16-
<command id="java.project.getProjectDependenciesWithResult" />
1715
</delegateCommandHandler>
1816
</extension>
1917
<extension

jdtls.ext/com.microsoft.jdtls.ext.core/src/com/microsoft/jdtls/ext/core/CommandHandler.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,6 @@ public Object executeCommand(String commandId, List<Object> arguments, IProgress
4141
return ProjectCommand.getImportClassContent(arguments, monitor);
4242
case "java.project.getDependencies":
4343
return ProjectCommand.getProjectDependencies(arguments, monitor);
44-
case "java.project.getImportClassContentWithResult":
45-
return ProjectCommand.getImportClassContentWithResult(arguments, monitor);
46-
case "java.project.getProjectDependenciesWithResult":
47-
return ProjectCommand.getProjectDependenciesWithResult(arguments, monitor);
4844
default:
4945
break;
5046
}

jdtls.ext/com.microsoft.jdtls.ext.core/src/com/microsoft/jdtls/ext/core/ProjectCommand.java

Lines changed: 2 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -480,24 +480,6 @@ public static boolean checkImportStatus() {
480480
return hasError;
481481
}
482482

483-
/**
484-
* Get import class content for Copilot integration (backward compatibility
485-
* wrapper).
486-
* This method maintains compatibility with the original return type.
487-
*
488-
* @param arguments List containing the file URI as the first element
489-
* @param monitor Progress monitor for cancellation support
490-
* @return List of ImportClassInfo containing class information and JavaDoc
491-
*/
492-
public static List<ImportClassInfo> getImportClassContent(List<Object> arguments, IProgressMonitor monitor) {
493-
ImportClassContentResult result = getImportClassContentWithResult(arguments, monitor);
494-
if (result.isEmpty) {
495-
// Log the error reason for debugging
496-
JdtlsExtActivator.logError("getImportClassContent failed: " + result.emptyReason);
497-
}
498-
return result.classInfoList;
499-
}
500-
501483
/**
502484
* Get import class content for Copilot integration.
503485
* This method extracts information about imported classes from a Java file.
@@ -508,7 +490,7 @@ public static List<ImportClassInfo> getImportClassContent(List<Object> arguments
508490
* @param monitor Progress monitor for cancellation support
509491
* @return List of ImportClassInfo containing class information and JavaDoc
510492
*/
511-
public static ImportClassContentResult getImportClassContentWithResult(List<Object> arguments,
493+
public static ImportClassContentResult getImportClassContent(List<Object> arguments,
512494
IProgressMonitor monitor) {
513495
if (arguments == null || arguments.isEmpty()) {
514496
return new ImportClassContentResult(ImportClassContentErrorReason.NULL_ARGUMENTS, null, null, null);
@@ -670,19 +652,14 @@ private static String getSeverityString(int severity) {
670652
}
671653
}
672654

673-
public static List<DependencyInfo> getProjectDependencies(List<Object> arguments, IProgressMonitor monitor) {
674-
ProjectDependenciesResult result = getProjectDependenciesWithResult(arguments, monitor);
675-
return result == null ? Collections.emptyList() : result.dependencyInfoList;
676-
}
677-
678655
/**
679656
* Get project dependencies information including JDK version.
680657
*
681658
* @param arguments List containing the file URI as the first element
682659
* @param monitor Progress monitor for cancellation support
683660
* @return List of DependencyInfo containing key-value pairs of project information
684661
*/
685-
public static ProjectDependenciesResult getProjectDependenciesWithResult(List<Object> arguments,
662+
public static ProjectDependenciesResult getProjectDependencies(List<Object> arguments,
686663
IProgressMonitor monitor) {
687664
if (arguments == null || arguments.isEmpty()) {
688665
return new ProjectDependenciesResult(ProjectDependenciesErrorReason.NULL_ARGUMENTS, null, null, null);

jdtls.ext/com.microsoft.jdtls.ext.core/src/com/microsoft/jdtls/ext/core/parser/ContextResolver.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,11 +71,11 @@ public class ContextResolver {
7171
*/
7272
public static class ImportClassInfo {
7373
public String uri; // File URI (required)
74-
public String className; // Human-readable class description with JavaDoc appended (required)
74+
public String value; // Human-readable class description with JavaDoc appended (required)
7575

7676
public ImportClassInfo(String uri, String value) {
7777
this.uri = uri;
78-
this.className = value;
78+
this.value = value;
7979
}
8080
}
8181

0 commit comments

Comments
 (0)