Skip to content

Commit 15b72b3

Browse files
[0.81] Bump fastfloat to 8.0.0 (#15419) (#15421)
1 parent d405028 commit 15b72b3

File tree

9 files changed

+42
-267
lines changed

9 files changed

+42
-267
lines changed
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "prerelease",
3+
"comment": "Bump fastfloat to 8.0.0",
4+
"packageName": "react-native-windows",
5+
"email": "[email protected]",
6+
"dependentChangeType": "patch"
7+
}

packages/e2e-test-app-fabric/test/__snapshots__/PressableComponentTest.test.ts.snap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -333,11 +333,11 @@ exports[`Pressable Tests Pressables can change style when pressed 1`] = `
333333
},
334334
"Comment": "style-change-pressable",
335335
"Offset": "0, 0, 0",
336-
"Size": "76, 33",
336+
"Size": "916, 33",
337337
"Visual Type": "SpriteVisual",
338338
"__Children": [
339339
{
340-
"Offset": "6, 6, 0",
340+
"Offset": "426, 6, 0",
341341
"Size": "64, 22",
342342
"Visual Type": "SpriteVisual",
343343
"__Children": [

packages/e2e-test-app-fabric/test/__snapshots__/ViewComponentTest.test.ts.snap

Lines changed: 20 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -452,10 +452,12 @@ exports[`View Tests Views can have backface visibility 1`] = `
452452
{
453453
"Type": "Microsoft.ReactNative.Composition.ViewComponentView",
454454
"_Props": {},
455-
},
456-
{
457-
"Type": "Microsoft.ReactNative.Composition.ParagraphComponentView",
458-
"_Props": {},
455+
"__Children": [
456+
{
457+
"Type": "Microsoft.ReactNative.Composition.ParagraphComponentView",
458+
"_Props": {},
459+
},
460+
],
459461
},
460462
{
461463
"Type": "Microsoft.ReactNative.Composition.ParagraphComponentView",
@@ -538,18 +540,20 @@ exports[`View Tests Views can have backface visibility 1`] = `
538540
"Offset": "0, 0, 0",
539541
"Size": "150, 150",
540542
"Visual Type": "SpriteVisual",
541-
},
542-
],
543-
},
544-
{
545-
"Offset": "393, 85, 0",
546-
"Size": "130, 38",
547-
"Visual Type": "SpriteVisual",
548-
"__Children": [
549-
{
550-
"Offset": "0, 0, 0",
551-
"Size": "130, 38",
552-
"Visual Type": "SpriteVisual",
543+
"__Children": [
544+
{
545+
"Offset": "10, 56, 0",
546+
"Size": "130, 38",
547+
"Visual Type": "SpriteVisual",
548+
"__Children": [
549+
{
550+
"Offset": "0, 0, 0",
551+
"Size": "130, 38",
552+
"Visual Type": "SpriteVisual",
553+
},
554+
],
555+
},
556+
],
553557
},
554558
],
555559
},

vnext/Directory.Build.props

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@
2727
<IncludeSource Condition="'$(Configuration)' == 'Release'">false</IncludeSource>
2828
<!-- When bumping the Folly version, be sure to bump the git hash of that version's commit, find the matching fastfloat dependency and build Folly.vcxproj (to update its cgmanifest.json) too. -->
2929
<FollyVersion>2024.10.14.00</FollyVersion>
30-
<FastFloatVersion>6.1.4</FastFloatVersion>
30+
<FastFloatVersion>8.0.0</FastFloatVersion>
3131
<FollyCommitHash>ad90720829db5ba0c3d0e44994856dcce33d7940</FollyCommitHash>
32-
<FastFloatCommitHash>ad90720829db5ba0c3d0e44994856dcce33d7940</FastFloatCommitHash>
32+
<FastFloatCommitHash>77cc847c842c49e7e3477c1e95da2b6540166d66</FastFloatCommitHash>
3333
<!-- When bumping the fmt version, be sure to bump the git hash of that version's commit and build fmt.vcxproj (to update its cgmanifest.json) too. -->
3434
<FmtVersion>10.1.0</FmtVersion>
3535
<FmtCommitHash>ca2e3685b160617d3d95fcd9e789c4e06ca88</FmtCommitHash>
@@ -52,6 +52,9 @@
5252
<FollyDir Condition="'$(FollyDir)' == '' AND Exists('$([MSBuild]::NormalizeDirectory($(ReactNativeDir)..\..\node_modules))')">$(ReactNativeDir)..\..\node_modules\.folly\folly-$(FollyVersion)</FollyDir>
5353
<FollyDir>$([MSBuild]::NormalizeDirectory($(FollyDir)))</FollyDir>
5454

55+
<FastFloatDir Condition="'$(FastFloatDir)' == '' AND Exists('$([MSBuild]::NormalizeDirectory($(ReactNativeDir)..\..\node_modules))')">$(ReactNativeDir)..\..\node_modules\.fastfloat\fast_float-$(FastFloatVersion)</FastFloatDir>
56+
<FastFloatDir>$([MSBuild]::NormalizeDirectory($(FastFloatDir)))</FastFloatDir>
57+
5558
<FmtDir Condition="'$(FmtDir)' == '' AND Exists('$([MSBuild]::NormalizeDirectory($(ReactNativeDir)..\..\node_modules))')">$(ReactNativeDir)..\..\node_modules\.fmt\fmt-$(FmtVersion)</FmtDir>
5659
<FmtDir>$([MSBuild]::NormalizeDirectory($(FmtDir)))</FmtDir>
5760

vnext/Folly/Folly.vcxproj

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,6 @@
243243
<ClInclude Include="$(FollyDir)\folly\Uri.h" />
244244
<ClInclude Include="$(FollyDir)\folly\Utility.h" />
245245
<ClInclude Include="$(FollyDir)\folly\Varint.h" />
246-
<ClInclude Include="$(FollyDir)\..\fast_float-6.1.4\include\fast_float\fast_float.h" />
247246
<ClInclude Include="pch.h" />
248247
</ItemGroup>
249248
<ItemGroup>
@@ -271,7 +270,7 @@
271270
<PrecompiledHeader>Use</PrecompiledHeader>
272271
<CompileAsWinRT>false</CompileAsWinRT>
273272
<SDLCheck>true</SDLCheck>
274-
<AdditionalIncludeDirectories>$(ReactNativeWindowsDir)stubs;$(FollyDir);$(FollyDir)\..\fast_float-6.1.4\include;$(FmtDir)\include;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
273+
<AdditionalIncludeDirectories>$(ReactNativeWindowsDir)stubs;$(FollyDir);$(FastFloatDir)\include;$(FmtDir)\include;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
275274
<PreprocessorDefinitions>FOLLY_CFG_NO_COROUTINES;FOLLY_NO_CONFIG;NOMINMAX;_CRT_SECURE_NO_WARNINGS;WINAPI_PARTITION_APP;%(PreprocessorDefinitions)</PreprocessorDefinitions>
276275
<ForcedUsingFiles />
277276
<DisableSpecificWarnings>4251;4293;4305;4800;4804;4310;%(DisableSpecificWarnings)</DisableSpecificWarnings>
@@ -292,8 +291,8 @@
292291
<CGManifestFile>$(MSBuildThisFileDirectory)cgmanifest.json</CGManifestFile>
293292
</PropertyGroup>
294293
<PropertyGroup>
295-
<FastFloatZipDir>$(FollyDir)..\.fastfloatzip</FastFloatZipDir>
296-
<FastFloatZipFile>$(FollyDir)..\.fastfloatzip\fastfloat.zip</FastFloatZipFile>
294+
<FastFloatZipDir>$(FastFloatDir)..\.fastfloatzip</FastFloatZipDir>
295+
<FastFloatZipFile>$(FastFloatZipDir)\fastfloat.zip</FastFloatZipFile>
297296
</PropertyGroup>
298297
<Target Name="DownloadFolly" BeforeTargets="PrepareForBuild" Inputs="$(FollyZipFile)" Outputs="$(FollyZipFile)">
299298
<Message Importance="High" Text="Downloading folly..." />
@@ -320,11 +319,11 @@
320319
OverwriteReadOnlyFiles="true" />
321320
</Target>
322321
<Target Name="UnzipFastFloat" BeforeTargets="PrepareForBuild" DependsOnTargets="DownloadFastFloat">
323-
<Message Condition="!Exists('$(FastFloatZipDir)\include\fast_float.h')" Importance="High" Text="Unzipping FastFloat to $([MSBuild]::NormalizePath($(FastFloatZipDir)..))." />
322+
<Message Condition="!Exists('$(FastFloatDir)\include\fast_float\fast_float.h')" Importance="High" Text="Unzipping FastFloat to $([MSBuild]::NormalizePath($(FastFloatDir)..))." />
324323
<Unzip
325-
Condition="!Exists('$(FastFloatZipDir)\include\fast_float.h')"
324+
Condition="!Exists('$(FastFloatDir)\include\fast_float\fast_float.h')"
326325
SourceFiles="$(FastFloatZipFile)"
327-
DestinationFolder="$([MSBuild]::NormalizePath($(FollyDir)..))"
326+
DestinationFolder="$([MSBuild]::NormalizePath($(FastFloatDir)..))"
328327
OverwriteReadOnlyFiles="true" />
329328
</Target>
330329
<Target Name="WriteCGManifest" BeforeTargets="PrepareForBuild" DependsOnTargets="DownloadFolly" Inputs="$(FollyZipFile)" Outputs="$(CGManifestFile)">

vnext/Folly/cgmanifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"Type": "git",
1717
"Git": {
1818
"RepositoryUrl": "https://github.com/fastfloat/fast_float",
19-
"CommitHash": "ad90720829db5ba0c3d0e44994856dcce33d7940"
19+
"CommitHash": "77cc847c842c49e7e3477c1e95da2b6540166d66"
2020
}
2121
},
2222
"DevelopmentDependency": false

vnext/PropertySheets/React.Cpp.props

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,7 @@
146146
<AdditionalIncludeDirectories>
147147
$(FollyDir);
148148
$(FmtDir)include;
149+
$(FastFloatDir)include;
149150
$(ReactNativeDir)\ReactCommon;
150151
$(ReactNativeDir)\ReactCommon\callinvoker;
151152
$(ReactNativeDir)\ReactCommon\jsi;

vnext/ReactCommon/TEMP_UntilReactCommonUpdate/react/renderer/css/CSSTokenizer.h

Lines changed: 0 additions & 232 deletions
This file was deleted.

0 commit comments

Comments
 (0)