copilot suggestions

Author: Max Wang

src/dataverse_sdk/client.py

@@ -274,12 +274,13 @@ def delete_async(
         if isinstance(ids, str):
             return od._delete_async(logical_name, [ids])
         elif isinstance(ids, list):
-            if not ids:
-                noop_bulkdelete_job_id = "00000000-0000-0000-0000-000000000000"
-                return noop_bulkdelete_job_id
             if not all(isinstance(rid, str) for rid in ids):
                 raise TypeError("ids must contain string GUIDs")
-            return od._delete_async(logical_name, ids)
+            sanitized = [rid.strip() for rid in ids if isinstance(rid, str) and rid.strip()]
+            if not sanitized:
+                noop_bulkdelete_job_id = "00000000-0000-0000-0000-000000000000"
+                return noop_bulkdelete_job_id
+            return od._delete_async(logical_name, sanitized)
         else:
             raise TypeError("ids must be str or list[str]")
 

src/dataverse_sdk/odata.py

@@ -319,15 +319,13 @@ def _delete_async(
         self,
         logical_name: str,
         ids: List[str],
-    ) -> Optional[str]:
+    ) -> str:
         """Delete many records by GUID list.
 
         Returns the asynchronous job identifier reported by the BulkDelete action.
         """
-        targets = [rid for rid in ids if rid]
-        if not targets:
-            return None
-        value_objects = [{"Value": rid, "Type": "System.Guid"} for rid in targets]
+        noop_job_id = "00000000-0000-0000-0000-000000000000"
+        value_objects = [{"Value": rid, "Type": "System.Guid"} for rid in ids]
 
         pk_attr = self._primary_id_attr(logical_name)
         timestamp = datetime.now(timezone.utc).isoformat(timespec="seconds").replace("+00:00", "Z")
@@ -368,15 +366,16 @@ def _delete_async(
         url = f"{self.api}/BulkDelete"
         response = self._request("post", url, json=payload, expected=(200, 202, 204))
 
-        job_id = None
         try:
             body = response.json() if response.text else {}
         except ValueError:
             body = {}
         if isinstance(body, dict):
             job_id = body.get("JobId")
+            if isinstance(job_id, str) and job_id.strip():
+                return job_id
 
-        return job_id
+        return noop_job_id
 
     def _format_key(self, key: str) -> str:
         k = key.strip()