Move libcurl/libuv HTTP client into acyclic http_client component

Move src/http/curl.h to src/http_client/curl.h, and src/http/test/curl_test.cpp
to src/http_client/test/curl_test.cpp, updating all in-tree includes and the
CMake registration. No forwarding header is left at the old path since curl.h
is an internal header.

Narrow the http component's declared internal dependencies to
[ccf-api, crypto, ds] now that the libuv-dependent client code has moved out,
and add the new http_client component with [ccf-api, ds, uv].

This keeps http protocol-focused and acyclic, and keeps the new http_client
component acyclic and outside the cyclic core.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: achamayou

.github/instructions/reviewing.instructions.md

@@ -58,7 +58,7 @@ Use this to verify that the correct check macro is used and that the error path
 
 ## libcurl
 
-CCF wraps libcurl in `src/http/curl.h`.
+CCF wraps libcurl in `src/http_client/curl.h`.
 
 | Macro                                        | Use when …                          |
 | -------------------------------------------- | ----------------------------------- |

CMakeLists.txt

@@ -1599,7 +1599,7 @@ if(BUILD_TESTS)
 
   add_test_bin(
     curl_test
-    ${CMAKE_CURRENT_SOURCE_DIR}/src/http/test/curl_test.cpp
+    ${CMAKE_CURRENT_SOURCE_DIR}/src/http_client/test/curl_test.cpp
   )
   target_link_libraries(curl_test PRIVATE curl uv http_parser)
 

scripts/source-dependencies.json

@@ -34,6 +34,7 @@
     "tls": ["crypto", "ds"],
     "udp": ["ds"],
     "uv": [],
-    "http": ["ccf-api", "crypto", "ds", "uv"]
+    "http": ["ccf-api", "crypto", "ds"],
+    "http_client": ["ccf-api", "ds", "uv"]
   }
 }

src/host/run.cpp

@@ -32,7 +32,7 @@
 #include "handle_ring_buffer.h"
 #include "host/env.h"
 #include "host/files_cleanup_timer.h"
-#include "http/curl.h"
+#include "http_client/curl.h"
 #include "json_schema.h"
 #include "lfs_file_handler.h"
 #include "node_connections.h"

src/http/curl.h src/http_client/curl.hsrc/http/curl.h renamed to src/http_client/curl.h

@@ -4,7 +4,7 @@
 #include "ccf/ds/json.h"
 #include "curl/curl.h"
 #include "ds/internal_logger.h"
-#include "http/curl.h"
+#include "http_client/curl.h"
 
 #include <cstdlib>
 #include <curl/header.h>

src/http/test/curl_test.cpp src/http_client/test/curl_test.cppsrc/http/test/curl_test.cpp renamed to src/http_client/test/curl_test.cpp

@@ -6,8 +6,8 @@
 #include "ccf/ds/nonstd.h"
 #include "ccf/service/tables/jwt.h"
 #include "enclave/http_rpc_context.h"
-#include "http/curl.h"
 #include "http/http_builder.h"
+#include "http_client/curl.h"
 #include "node/rpc/node_frontend.h"
 #include "tasks/basic_task.h"
 #include "tasks/task_system.h"

src/node/jwt_key_auto_refresh.h

@@ -30,8 +30,8 @@
 #include "enclave/rpc_sessions.h"
 #include "encryptor.h"
 #include "history.h"
-#include "http/curl.h"
 #include "http/http_parser.h"
+#include "http_client/curl.h"
 #include "indexing/indexer.h"
 #include "js/global_class_ids.h"
 #include "network_state.h"

src/node/node_state.h

@@ -8,7 +8,7 @@
 #include "ccf/http_consts.h"
 #include "ccf/pal/attestation.h"
 #include "ccf/pal/attestation_sev_snp_endorsements.h"
-#include "http/curl.h"
+#include "http_client/curl.h"
 #include "tasks/basic_task.h"
 #include "tasks/task.h"
 #include "tasks/task_system.h"

src/node/quote_endorsements_client.h

@@ -9,7 +9,7 @@
 #include "ccf/service/tables/self_healing_open.h"
 #include "ccf/tx.h"
 #include "ccf/tx_id.h"
-#include "http/curl.h"
+#include "http_client/curl.h"
 #include "node_state.h"
 #include "tasks/basic_task.h"
 #include "tasks/task_system.h"