Commit ff7effb
error handling on mcclComm::init
Summary:
Arguably, the capture scope is very wide. The reason is that some of the errors should be crashing quickly, while others should be retried.
I found a really small number of cases, where `std::runtime_error` is used in place of something more suitable, such as an `invalid_argument`. We will follow up to clean these up, so that non-recoverable items would fail fast and recoverable ones are handled by Mccl. But these findings are harmless for initial enablement.
Reviewed By: dboyda
Differential Revision: D85824307
fbshipit-source-id: 1c5b4e647ccb3ee7f2eaad927071dd8f40411b891 parent 9917f03 commit ff7effb
File tree
2 files changed
+11
-1
lines changed- comms/ctran/mapper/tests
2 files changed
+11
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| 38 | + | |
| 39 | + | |
38 | 40 | | |
39 | 41 | | |
40 | 42 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
115 | | - | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
116 | 124 | | |
117 | 125 | | |
118 | 126 | | |
| |||
0 commit comments