Skip to content

Commit 1153cf9

Browse files
terencelijasowang
authored andcommitted
qtest: add tulip test case
The tulip networking card emulation has an OOB issue in 'tulip_copy_tx_buffers' when the guest provide malformed descriptor. This test will trigger a ASAN heap overflow crash. To trigger this issue we can construct the data as following: 1. construct a 'tulip_descriptor'. Its control is set to '0x7ff | 0x7ff << 11', this will make the 'tulip_copy_tx_buffers's 'len1' and 'len2' to 0x7ff(2047). So 'len1+len2' will overflow 'TULIPState's 'tx_frame' field. This descriptor's 'buf_addr1' and 'buf_addr2' should set to a guest address. 2. write this descriptor to tulip device's CSR4 register. This will set the 'TULIPState's 'current_tx_desc' field. 3. write 'CSR6_ST' to tulip device's CSR6 register. This will trigger 'tulip_xmit_list_update' and finally calls 'tulip_copy_tx_buffers'. Following shows the backtrack of crash: ==31781==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x628000007cd0 at pc 0x7fe03c5a077a bp 0x7fff05b46770 sp 0x7fff05b45f18 WRITE of size 2047 at 0x628000007cd0 thread T0 #0 0x7fe03c5a0779 (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x79779) #1 0x5575fb6daa6a in flatview_read_continue /home/test/qemu/exec.c:3194 #2 0x5575fb6daccb in flatview_read /home/test/qemu/exec.c:3227 #3 0x5575fb6dae66 in address_space_read_full /home/test/qemu/exec.c:3240 #4 0x5575fb6db0cb in address_space_rw /home/test/qemu/exec.c:3268 qemu#5 0x5575fbdfd460 in dma_memory_rw_relaxed /home/test/qemu/include/sysemu/dma.h:87 qemu#6 0x5575fbdfd4b5 in dma_memory_rw /home/test/qemu/include/sysemu/dma.h:110 qemu#7 0x5575fbdfd866 in pci_dma_rw /home/test/qemu/include/hw/pci/pci.h:787 qemu#8 0x5575fbdfd8a3 in pci_dma_read /home/test/qemu/include/hw/pci/pci.h:794 qemu#9 0x5575fbe02761 in tulip_copy_tx_buffers hw/net/tulip.c:585 qemu#10 0x5575fbe0366b in tulip_xmit_list_update hw/net/tulip.c:678 qemu#11 0x5575fbe04073 in tulip_write hw/net/tulip.c:783 Signed-off-by: Li Qiang <[email protected]> Signed-off-by: Jason Wang <[email protected]>
1 parent b88fb12 commit 1153cf9

File tree

2 files changed

+92
-0
lines changed

2 files changed

+92
-0
lines changed

tests/qtest/Makefile.include

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -217,6 +217,7 @@ qos-test-obj-y += tests/qtest/es1370-test.o
217217
qos-test-obj-y += tests/qtest/ipoctal232-test.o
218218
qos-test-obj-y += tests/qtest/megasas-test.o
219219
qos-test-obj-y += tests/qtest/ne2000-test.o
220+
qos-test-obj-y += tests/qtest/tulip-test.o
220221
qos-test-obj-y += tests/qtest/nvme-test.o
221222
qos-test-obj-y += tests/qtest/pca9552-test.o
222223
qos-test-obj-y += tests/qtest/pci-test.o

tests/qtest/tulip-test.c

Lines changed: 91 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,91 @@
1+
/*
2+
* QTest testcase for DEC/Intel Tulip 21143
3+
*
4+
* Copyright (c) 2020 Li Qiang <[email protected]>
5+
*
6+
* This work is licensed under the terms of the GNU GPL, version 2 or later.
7+
* See the COPYING file in the top-level directory.
8+
*/
9+
10+
#include "qemu/osdep.h"
11+
#include "libqtest.h"
12+
#include "qemu/module.h"
13+
#include "libqos/qgraph.h"
14+
#include "libqos/pci.h"
15+
#include "qemu/bitops.h"
16+
#include "hw/net/tulip.h"
17+
18+
typedef struct QTulip_pci QTulip_pci;
19+
20+
struct QTulip_pci {
21+
QOSGraphObject obj;
22+
QPCIDevice dev;
23+
};
24+
25+
static void *tulip_pci_get_driver(void *obj, const char *interface)
26+
{
27+
QTulip_pci *tulip_pci = obj;
28+
29+
if (!g_strcmp0(interface, "pci-device")) {
30+
return &tulip_pci->dev;
31+
}
32+
33+
fprintf(stderr, "%s not present in tulip_pci\n", interface);
34+
g_assert_not_reached();
35+
}
36+
37+
static void *tulip_pci_create(void *pci_bus, QGuestAllocator *alloc, void *addr)
38+
{
39+
QTulip_pci *tulip_pci = g_new0(QTulip_pci, 1);
40+
QPCIBus *bus = pci_bus;
41+
42+
qpci_device_init(&tulip_pci->dev, bus, addr);
43+
tulip_pci->obj.get_driver = tulip_pci_get_driver;
44+
45+
return &tulip_pci->obj;
46+
}
47+
48+
static void tulip_large_tx(void *obj, void *data, QGuestAllocator *alloc)
49+
{
50+
QTulip_pci *tulip_pci = obj;
51+
QPCIDevice *dev = &tulip_pci->dev;
52+
QPCIBar bar;
53+
struct tulip_descriptor context;
54+
char guest_data[4096];
55+
uint64_t context_pa;
56+
uint64_t guest_pa;
57+
58+
qpci_device_enable(dev);
59+
bar = qpci_iomap(dev, 0, NULL);
60+
context_pa = guest_alloc(alloc, sizeof(context));
61+
guest_pa = guest_alloc(alloc, 4096);
62+
memset(guest_data, 'A', sizeof(guest_data));
63+
context.status = TDES0_OWN;
64+
context.control = TDES1_BUF2_SIZE_MASK << TDES1_BUF2_SIZE_SHIFT |
65+
TDES1_BUF1_SIZE_MASK << TDES1_BUF1_SIZE_SHIFT;
66+
context.buf_addr2 = guest_pa;
67+
context.buf_addr1 = guest_pa;
68+
69+
qtest_memwrite(dev->bus->qts, context_pa, &context, sizeof(context));
70+
qtest_memwrite(dev->bus->qts, guest_pa, guest_data, sizeof(guest_data));
71+
qpci_io_writel(dev, bar, 0x20, context_pa);
72+
qpci_io_writel(dev, bar, 0x30, CSR6_ST);
73+
guest_free(alloc, context_pa);
74+
guest_free(alloc, guest_pa);
75+
}
76+
77+
static void tulip_register_nodes(void)
78+
{
79+
QOSGraphEdgeOptions opts = {
80+
.extra_device_opts = "addr=04.0",
81+
};
82+
add_qpci_address(&opts, &(QPCIAddress) { .devfn = QPCI_DEVFN(4, 0) });
83+
84+
qos_node_create_driver("tulip", tulip_pci_create);
85+
qos_node_consumes("tulip", "pci-bus", &opts);
86+
qos_node_produces("tulip", "pci-device");
87+
88+
qos_add_test("tulip_large_tx", "tulip", tulip_large_tx, NULL);
89+
}
90+
91+
libqos_init(tulip_register_nodes);

0 commit comments

Comments
 (0)