Fix FlatFile data truncation on read failure and float XP parsing

Signed-off-by: Cyrne1_7208 <127477265+cyrne1-7208@users.noreply.github.com>

Author: cyrne1-7208

src/main/java/com/gmail/nossr50/database/FlatFileDatabaseManager.java

@@ -263,12 +263,11 @@ public int purgePowerlessUsers() {
                         purgedUsers++;
                     }
                 }
+                writeStringToFileSafely(writer.toString());
             } catch (IOException e) {
                 logger.severe("Exception while reading " + usersFilePath
                         + " (Are you sure you formatted it correctly?)" + e);
             }
-
-            writeStringToFileSafely(writer.toString());
         }
 
         logger.info("Purged " + purgedUsers + " users from the database.");
@@ -289,7 +288,7 @@ public void purgeOldUsers() {
             }
 
             String[] data = row.fields();
-            if (data.length <= UUID_INDEX) {
+            if (data.length <= OVERHAUL_LAST_LOGIN) {
                 // Not enough fields; preserve line
                 return line;
             }
@@ -777,22 +776,23 @@ public boolean saveUserUUID(String userName, UUID uuid) {
                             logger.severe("Database entry is invalid.");
                             // still append original line
                         } else {
-                            line = line.replace(character[UUID_INDEX], uuid.toString());
+                            character[UUID_INDEX] = uuid.toString();
+                            line = org.apache.commons.lang3.StringUtils.join(character, ":") + ":";
                             worked = true;
                         }
                     }
 
                     entriesWritten++;
                     writer.append(line).append(LINE_ENDING);
                 }
+
+                LogUtils.debug(logger,
+                        entriesWritten + " entries written while saving UUID for " + userName);
+                writeStringToFileSafely(writer.toString());
             } catch (Exception e) {
                 logger.severe("Exception while reading " + usersFilePath
                         + " (Are you sure you formatted it correctly?)" + e);
             }
-
-            LogUtils.debug(logger,
-                    entriesWritten + " entries written while saving UUID for " + userName);
-            writeStringToFileSafely(writer.toString());
         }
 
         return worked;
@@ -1197,7 +1197,7 @@ private void tryLoadSkillFloatValuesFromRawData(@NotNull Map<PrimarySkillType, F
             @NotNull String[] character, @NotNull PrimarySkillType primarySkillType, int index,
             @NotNull String userName) {
         try {
-            float valueFromString = Integer.parseInt(character[index]);
+            float valueFromString = Float.parseFloat(character[index]);
             skillMap.put(primarySkillType, valueFromString);
         } catch (NumberFormatException e) {
             skillMap.put(primarySkillType, 0F);
@@ -1281,12 +1281,11 @@ private void rewriteUsersFile(@NotNull Function<String, String> lineMapper) {
                         writer.append(mapped).append(LINE_ENDING);
                     }
                 }
+                writeStringToFileSafely(writer.toString());
             } catch (IOException e) {
                 logger.severe("Exception while reading " + usersFilePath
                         + " (Are you sure you formatted it correctly?)" + e);
             }
-
-            writeStringToFileSafely(writer.toString());
         }
     }
 

src/test/java/com/gmail/nossr50/database/FlatFileDatabaseManagerTest.java

@@ -534,6 +534,24 @@ void saveUserUuidWithShortEntryDoesNotModifyDataAndReturnsFalse() throws IOExcep
         }
     }
 
+    @Test
+    void loadPlayerProfileWithFloatingPointXpLoadsAccurately() throws IOException {
+        // Given
+        var databaseManager = new FlatFileDatabaseManager(
+                new File(getTemporaryUserFilePath()), logger, PURGE_TIME, 0, true);
+
+        // Replace mining XP (field index 4) with a floating point number "10.5"
+        String floatXpLine = normalDatabaseData[0].replace(":10:2:", ":10.5:2:");
+        replaceDataInFile(databaseManager, new String[]{floatXpLine});
+
+        // When
+        var profile = databaseManager.loadPlayerProfile("nossr50");
+
+        // Then
+        assertTrue(profile.isLoaded());
+        assertEquals(10.5f, profile.getSkillXpLevelRaw(PrimarySkillType.MINING), 0.001f);
+    }
+
     @Test
     void convertUsersCopiesAllNonCommentLinesToDestination() throws IOException {
         // Given