Skip to content

Conversation

@magneticflux-
Copy link

@magneticflux- magneticflux- commented Jul 6, 2019

This has a lot of changes, but I hope it will make it more maintainable for the future.

This also includes #68

@magneticflux-
Copy link
Author

This version is temporarily published here until it's ready/approved.

@sante85 sante85 marked this pull request as ready for review July 15, 2019 07:56
@sante85
Copy link
Collaborator

sante85 commented Jul 16, 2019

please redo a pull request

@magneticflux-
Copy link
Author

@sante85 Could you clarify what you want me to do?
Do you mean that I should rebase it (which I can do easily) or that I shouldn't make so many changes to the structure of the project (which would take time, and I don't believe is the best course)?

# Conflicts:
#	src/resource-array.ts
#	src/resource-helper.ts
#	src/resource.service.ts
#	src/resource.ts
@sante85 sante85 merged commit eafe65a into masvis:8.x Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants