-
Notifications
You must be signed in to change notification settings - Fork 458
feat(broker): add custom broker API endpoint and refactor zerodha API calls #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… calls - Introduce new RESTX endpoint for custom broker API requests - Extract common API response logic into shared module for zerodha - Refactor funds and order APIs to use shared API response module
|
@marketcalls if it is okay for zerodha, I can do the same for other brokers too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 7 files
|
What's the benefit of using the custom broker endpoint? |
|
Example: Open algo dont have feature to calculate the margin required to execute the option strategies, create the alerts or alert triggered order. In my case I use zerodha, they have api to
Similarly Dhan have option to get the option chain, option expiry list, option geeks. with my above implementation,using openalgo api I can directly execute my broker's api, without needing to go through extra authentication layer with broker again. I can pass the endpoint, method and payload to execute my brokers api call through openalgo api.. we can execute brokers' api through openalgo without needing to go through seperate implementation |
|
Was it any different from #564 |
|
@crypt0inf0 yes, it is different,
Also dhan offers, historical price for expired options, powerfull option chain with geeks.
I can execute all these, without waiting for openalgo to implement, say for example, we need to wait for openalgo to implement #564 for margin calculation but with this custom broker api execution we can directly use zerodha one without needing to wait for openalgo implementation |
|
I understand your idea and your implementation but most of the openalgo users are non technical user's. They want a simple user experience. Can you give a example of how to use this custom API? |
1 similar comment
|
I understand your idea and your implementation but most of the openalgo users are non technical user's. They want a simple user experience. Can you give a example of how to use this custom API? |
|
@crypt0inf0 , I agree this is not for non-technical users, but technical people can easily call this, We can update the python, node sdk to access this easiy without using |
|
@kalai-de Now I understand we can directly use the broker API endpoint via openalgo @marketcalls Can you test this and merge it? |
|
im exploring it |



#561, We can extend broker functionalities directly with this new endpoint,
we can extend individual brokers cabality depending on broker that we are using.
Summary by cubic
Adds a custom broker RESTX endpoint and centralizes Zerodha API request handling to cut duplication and simplify maintenance. This makes funds and order APIs cleaner and makes it easier to extend support for more brokers.
New Features
Refactors
Written for commit 3b9beba. Summary will update automatically on new commits.