xmlsec 1.3.7 build failed with error C2220

[rongz609]

Error was reported by cl.exe :
cl.exe /nologo /D "WIN32" /D "_WINDOWS" /D inline=__inline /D "_MBCS" /D "_REENTRANT" /D PACKAGE="xmlsec" /D "HAVE_STDIO_H" /D "HAVE_STDLIB_H" /D "HAVE_STRING_H" /D "HAVE_CTYPE_H" /D "HAVE_MALLOC_H" /D "HAVE_MEMORY_H" /D "WIN32_LEAN_AND_MEAN" /I.. /I..\include /Id:\build\ob\sb-86016457\publish\win32_vc140\include /D "XMLSEC_NO_GOST" /D "XMLSEC_NO_GOST2012" /D "XMLSEC_NO_MD5" /D "XMLSEC_NO_RIPEMD160" /D "XMLSEC_NO_FTP" /D "XMLSEC_NO_HTTP" /W4 /wd4127 /wd4130 /wd4152 /wd4232 /WX /D "UNICODE" /D "_UNICODE" /D "NDEBUG" /O2 /Zi /MD /DXMLSEC_NO_XSLT=1 /D "XMLSEC_DEFAULT_CRYPTO=""openssl""" /D "XMLSEC_DL_WIN32" /D "XMLSEC_CRYPTO_OPENSSL" /D "XMLSEC_DEFAULT_CRYPTO="openssl"" /D "XMLSEC_OPENSSL3_ENGINES=1" /Folibxmlsec_openssl.int\ /c ..\src\openssl\app.c ..\src\openssl\ciphers.c ..\src\openssl\crypto.c ..\src\openssl\digests.c ..\src\openssl\evp.c ..\src\openssl\hmac.c ..\src\openssl\kdf.c ..\src\openssl\key_agrmnt.c ..\src\openssl\keysstore.c ..\src\openssl\kt_rsa.c ..\src\openssl\kw_aes.c ..\src\openssl\kw_des.c ..\src\openssl\signatures.c ..\src\openssl\signatures_legacy.c ..\src\openssl\symkeys.c ..\src\openssl\x509.c ..\src\openssl\x509vfy.c

app.c
..\src\openssl\app.c(511): error C2220: the following warning is treated as an error
..\src\openssl\app.c(511): warning C4996: 'ENGINE_by_id': Since OpenSSL 3.0
..\src\openssl\app.c(513): warning C4996: 'ENGINE_by_id': Since OpenSSL 3.0
..\src\openssl\app.c(515): warning C4996: 'ENGINE_ctrl_cmd_string': Since OpenSSL 3.0
..\src\openssl\app.c(519): warning C4996: 'ENGINE_ctrl_cmd_string': Since OpenSSL 3.0
..\src\openssl\app.c(526): warning C4996: 'ENGINE_ctrl_cmd': Since OpenSSL 3.0
..\src\openssl\app.c(530): warning C4996: 'ENGINE_set_default': Since OpenSSL 3.0
..\src\openssl\app.c(534): warning C4996: 'ENGINE_init': Since OpenSSL 3.0
..\src\openssl\app.c(543): warning C4996: 'ENGINE_load_private_key': Since OpenSSL 3.0
..\src\openssl\app.c(545): warning C4996: 'ENGINE_load_public_key': Since OpenSSL 3.0
..\src\openssl\app.c(552): warning C4996: 'ENGINE_load_private_key': Since OpenSSL 3.0
..\src\openssl\app.c(558): warning C4996: 'ENGINE_load_public_key': Since OpenSSL 3.0
..\src\openssl\app.c(598): warning C4996: 'ENGINE_finish': Since OpenSSL 3.0
..\src\openssl\app.c(600): warning C4996: 'ENGINE_free': Since OpenSSL 3.0

[rongz609]

I can add /wd4996 to inhibit the warning C4996 reported by the deprecated APIs ENGINE_* in OpenSSL 3.0.
For long term solution, looks like that the deprecated "ENGINE_*" APIs need to be modified to be compatible with OpenSSL 3.0.
Do we have plan to do that?
Thanks.

[lsh123]

Check the flags for configure.js, looks like you have 'with-openssl3-engines' flag set and your OpenSSL build does NOT have engines built in.

[rongz609]

Check the flags for configure.js, looks like you have 'with-openssl3-engines' flag set and your OpenSSL build does NOT have engines built in.

Thanks.
I checked my OpenSSL build, it has Engine built in.
C:\Users\Administrator\Downloads\openssl\win64_vc140\bin>openssl.exe engine
(rdrand) Intel RDRAND engine
(dynamic) Dynamic engine loading support

I used the same OpenSSL build for the xmlsec 1.3.5 build, and the xmlsec 1.3.5 could succeed with the same warnings.
Noticed that the build error in xmlsec 1.3.7 occurred due to the /WX flag being enabled (warnings are treated as error).

I will check whether the OpenSSL engine is needed in my project, if it's not needed, I can disable it by setting the XMLSEC_OPENSSL3_ENGINES flag to false.

[rongz609]

Hi @lsh123
Could you please confirm whether the xmlsec 1.3.7 build can succeed with the with-openssl3-engines=yes ?
I'm trying to understand if I have to use with-openssl3-engines=false in xmlsec 1.3.7 build.
BTW, my OpenSSL build version is 3.0.16.
Thanks in advance.

[lsh123]

11Sorry I am traveling and missed your question. I can't test it on Windows at the moment but if your OpenSSL is built without engines then you MUST use with-openssl3-engines=no (similar option works correctly on Linux). Please let me know if you run into any problems -- I will be happy to check it out in 2-3 weeks.

[simo5]

Engines are deprecated, you should phase them out unless you have a need for a specific engine and there is no equivalent modern openssl provider for that functionality.

[lsh123]

I confirmed running the configure script on windows as follows:

cscript configure.js with-openss3-engines=no

disables Engines compilation in XMLSec. Specifically the /D "XMLSEC_OPENSSL3_ENGINES=1" define is REMOVED from the compile flags.

Please reopen if you still have problems and show the configuration command line and output.

[lsh123]

I confirmed running the configure script on windows as follows:

cscript configure.js with-openss3-engines=no

disables Engines compilation in XMLSec. Specifically the /D "XMLSEC_OPENSSL3_ENGINES=1" define is REMOVED from the compile flags.

Please reopen if you still have problems and show the configuration command line and output.