Skip to content

Conversation

@aversey
Copy link
Contributor

@aversey aversey commented Nov 28, 2025

No description provided.

@aversey aversey self-assigned this Nov 28, 2025
@aversey
Copy link
Contributor Author

aversey commented Dec 5, 2025

The checks fail because main of hopsworks-api is used. See https://aversey.github.io/logicalclocks.github.io/latest/ for results and https://github.com/aversey/logicalclocks.github.io/actions/runs/19969615418/job/57270781705 for the last check (the one before Final change).

@aversey aversey requested review from Copilot, robzor92 and vatj December 5, 2025 16:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the documentation building process by modernizing dependencies, introducing new documentation tools, and standardizing markdown formatting across documentation files.

Key changes:

  • Updated documentation dependencies to latest versions (mkdocs 1.6.1, mkdocs-material 9.7.0)
  • Replaced custom macro/jupyter plugins with mkdocs-multirepo-plugin and mkdocstrings for API documentation
  • Standardized markdown formatting by breaking long lines into multiple lines

Reviewed changes

Copilot reviewed 203 out of 208 changed files in this pull request and generated 1 comment.

File Description
requirements-docs.txt Updated documentation dependencies to latest versions
mkdocs.yml Replaced custom plugins with mkdocstrings, added multirepo support, enabled dark mode theme
docs/user_guides/**/*.md Broke long sentences into multiple lines for better readability
docs/js/dropdown.js Removed custom dropdown JavaScript (no longer needed)
Comments suppressed due to low confidence (1)

mkdocs.yml:1

  • The cross-reference links contain incorrect step numbers. Step 4 links to #step-6-optional-enable-kserve and Step 5 links to #step-7-optional-other-advanced-options, but they should link to #step-4-optional-enable-kserve and #step-5-optional-other-advanced-options respectively.
site_name: "Hopsworks Documentation"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@aversey
Copy link
Contributor Author

aversey commented Dec 5, 2025

See logicalclocks/hopsworks-api#738 for the related PR.

@aversey aversey enabled auto-merge (squash) December 5, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant