potentially removing the "effective" keyword from maximizer calls

[docrostov]

[docrostov]

here is where we'd probably want to modify it:

autoscend/RELEASE/scripts/autoscend/auto_equipment.ash

Line 926 in fac7183

addToMaximize("effective");

here, it's encased in an if/else statement; we could add ownership of certain iotm weapons as a condition here to ensure no-shiny still uses effective but shiny w/ good weapons does not. my recommendation would be to add if coverage for ownership of various IOTM weapons that aren't getting properly equipped, and if they own those, do not add effective to the maximizer string.

(my initial thought would be CCSC, cleaver, fourth of may cosplay saber, industrial fire extinguisher, mchugelarge poles, monodent, and LSCC. there may be a few more worth calling out tho, that's just a "top of mind" guess

[Alium58]

Mafia updated recently to treat weapons that can't miss as effective, what if we did the same? Look in inventory and only apply "effective" to maximizer if we don't have a weapon that can't miss.

[midgleyc]

I think you probably want to remove it entirely in most cases. If you're a Moxie class, your moxie is higher than your muscle, so "effective" will prefer a ranged weapon -- but your best iotm is probably better than your best ranged weapon.

e.g. Monodent likely beats boot knife as a Disco Bandit