pr comments

Author: anunaym14

Cargo.lock

@@ -27,8 +27,6 @@ futures-util = { version = "0.3", default-features = false, features = ["sink"]
 parking_lot = { version = "0.12", features = ["deadlock_detection"] }
 prost = "0.12"
 prost-types = "0.12"
-pbjson = "0.6"
-pbjson-types = "0.6"
 lazy_static = "1.4"
 thiserror = "1.0"
 log = "0.4"

livekit-ffi/Cargo.toml

@@ -20,8 +20,6 @@ OUT_RUST=src
 protoc \
     -I=$PROTOCOL \
     --prost_out=$OUT_RUST \
-    --prost_opt=compile_well_known_types \
-    --prost_opt=extern_path=.google.protobuf=::pbjson_types \
     $PROTOCOL/ffi.proto \
     $PROTOCOL/handle.proto \
     $PROTOCOL/room.proto \
@@ -33,5 +31,4 @@ protoc \
     $PROTOCOL/e2ee.proto \
     $PROTOCOL/stats.proto \
     $PROTOCOL/rpc.proto \
-    $PROTOCOL/data_stream.proto \
-    $PROTOCOL/metrics.proto
+    $PROTOCOL/data_stream.proto

livekit-ffi/generate_proto.sh

@@ -20,8 +20,6 @@ set OUT_RUST=src
 protoc.exe ^
     -I=%PROTOCOL% ^
     --prost_out=%OUT_RUST% ^
-    --prost_opt=compile_well_known_types ^
-    --prost_opt=extern_path=.google.protobuf=::pbjson_types ^
     %PROTOCOL%/ffi.proto ^
     %PROTOCOL%/handle.proto ^
     %PROTOCOL%/room.proto ^
@@ -33,5 +31,4 @@ protoc.exe ^
     %PROTOCOL%/e2ee.proto ^
     %PROTOCOL%/stats.proto ^
     %PROTOCOL%/rpc.proto ^
-    %PROTOCOL%/data_stream.proto ^
-    %PROTOCOL%/metrics.proto
+    %PROTOCOL%/data_stream.proto

livekit-ffi/generate_proto_win.bat

@@ -26,7 +26,6 @@ import "video_frame.proto";
 import "audio_frame.proto";
 import "rpc.proto";
 import "data_stream.proto";
-import "metrics.proto";
 
 // **How is the livekit-ffi working:
 // We refer as the ffi server the Rust server that is running the LiveKit client implementation, and we
@@ -308,10 +307,9 @@ message FfiEvent {
 
 message PublishMetricsRequest {
   required uint64 local_participant_handle = 1;
-  repeated string str_data = 2;
-  repeated TimeSeriesMetric time_series = 3;
-  repeated EventMetric events = 4;
-  optional uint64 async_id = 5;
+  required uint64 data_ptr = 2;
+  required uint64 data_len = 3;
+  optional uint64 async_id = 4;
 }
 
 message PublishMetricsResponse {

livekit-ffi/protocol/ffi.proto

@@ -20,4 +20,3 @@ pub mod room;
 pub mod stats;
 pub mod track;
 pub mod video_frame;
-pub mod metrics;