fix: remove file_select_component changes that belong to PR #3157

Author: dl-alexandre

lib/livebook_web/live/file_select_component.ex

@@ -523,7 +523,7 @@ defmodule LivebookWeb.FileSelectComponent do
     send_event(socket.assigns.target, {:mount_file_system, file_system})
     send_event(socket.assigns.target, {:set_file, file, %{exists: true}})
 
-    {:noreply, socket}
+    {:noreply, assign(socket, loading: true)}
   end
 
   def handle_event("set_path", %{"path" => path}, socket) do
@@ -544,7 +544,7 @@ defmodule LivebookWeb.FileSelectComponent do
       end
 
     send_event(socket.assigns.target, {:set_file, file, info})
-    {:noreply, socket}
+    {:noreply, assign(socket, loading: socket.assigns.file.path != path)}
   end
 
   def handle_event("clear_error", %{}, socket) do
@@ -640,13 +640,8 @@ defmodule LivebookWeb.FileSelectComponent do
     current_file_infos = assigns[:file_infos] || []
     {dir, prefix} = dir_and_prefix(assigns.file)
 
-    dir_changed? = dir != assigns.current_dir
-
-    # Only show loading when changing directories (which requires listing files)
-    socket = if dir_changed?, do: assign(socket, :loading, true), else: socket
-
     {file_infos, socket} =
-      if dir_changed? or force_reload? do
+      if dir != assigns.current_dir or force_reload? do
         case get_file_infos(dir, assigns.extnames, assigns.running_files) do
           {:ok, file_infos} ->
             {file_infos, assign(socket, :current_dir, dir)}

test/livebook_web/live/file_select_component_test.exs

@@ -23,45 +23,6 @@ defmodule LivebookWeb.FileSelectComponentTest do
     refute render_component(FileSelectComponent, attrs(file: file)) =~ ".."
   end
 
-  test "shows loading when changing directories" do
-    file = FileSystem.File.local(notebooks_path() <> "/")
-
-    # Initial render in one directory
-    html = render_component(FileSelectComponent, attrs(file: file))
-
-    # Loading should not be shown after initial render
-    refute html =~ ~s(role="status")
-
-    # Simulate changing to a different directory via send_update with a new file
-    new_file = FileSystem.File.local(p("/"))
-
-    html = render_component(FileSelectComponent, attrs(file: new_file))
-
-    # After changing directory, loading should be reset to false after listing
-    refute html =~ ~s(role="status")
-  end
-
-  test "does not show loading when only running_files changes" do
-    file = FileSystem.File.local(notebooks_path() <> "/")
-    running_file = FileSystem.File.local(notebooks_path() <> "/basic.livemd")
-
-    # Initial render with no running files
-    html = render_component(FileSelectComponent, attrs(file: file, running_files: []))
-
-    refute html =~ ~s(role="status")
-    # Verify basic.livemd is shown but not marked as running
-    assert html =~ "basic.livemd"
-    refute html =~ "play-circle-line"
-
-    # Update with running_files changed
-    html = render_component(FileSelectComponent, attrs(file: file, running_files: [running_file]))
-
-    # Loading should not be shown when only running_files changes
-    refute html =~ ~s(role="status")
-    # Verify basic.livemd is now marked as running
-    assert html =~ "play-circle-line"
-  end
-
   defp attrs(attrs) do
     Keyword.merge(
       [