Skip to content

Commit 4b4c600

Browse files
authored
Do not use ReportFatalError in Start(), it will deadlock (#55)
1 parent c3cb586 commit 4b4c600

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

generatorreceiver/generator_receiver.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,12 +47,12 @@ func (g generatorReceiver) loadTopoFile(topoInline string, path string) (topoFil
4747
func (g generatorReceiver) Start(ctx context.Context, host component.Host) error {
4848
topoFile, err := g.loadTopoFile(g.topoInline, g.topoPath)
4949
if err != nil {
50-
host.ReportFatalError(err)
50+
return fmt.Errorf("could not load topo file: %w", err)
5151
}
5252

5353
err = validateConfiguration(*topoFile)
5454
if err != nil {
55-
host.ReportFatalError(err)
55+
return fmt.Errorf("could not validate topo file: %w", err)
5656
}
5757

5858
g.logger.Info("starting flag manager", zap.Int("flag_count", flags.Manager.FlagCount()))
@@ -160,7 +160,6 @@ func (g *generatorReceiver) startMetricGenerator(ctx context.Context, host compo
160160
host.ReportFatalError(err)
161161
}
162162
}
163-
164163
}
165164
}()
166165

0 commit comments

Comments
 (0)