Skip to content

[Feature] Ask user to setup a pin #106

Description

@alvinlollo

Note

Please read our Contributing Guidelines to understand how to get involved. For new features, it is highly recommended to discuss the implementation details in our communication channels before submitting a PR.

Before submitting a feature request, check the following checklist:

  • I have searched the existing issues/discussions to ensure this hasn't been proposed before
  • I have confirmed this feature is within the scope of PicoForge/LibreKeys
  • I am using the latest version of PicoForge

Proposed Feature

Ask the user to setup a pin when changing settings that need authentication if they haven't set one up yet. Or when they connect their key with the ability to dismiss.

Is your feature request related to a problem?

When attempting to authenticate to change settings on my device it does not ask me to setup a pin for the device and instead expects that there's a pin setup on the key already.

Describe the solution you'd like

Ask the user to setup a pin on their device when changing settings or plugging in a key without a pin.

Describe alternatives you've considered

None

How would this improve the user experience?

This will reduce confusion and make the user more secure by putting a pin on their device.

Implementation Details (Optional)

Check if a pin is on the key on startup then make a prompt to setup a pin to make their key more secure. Then when a authentication prompt is triggered and they don't have a pin to show a prompt to setup a pin.

Proposed Hardware/Firmware Impact

None

Additional Context

Visual Aids (Optional)

Image

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions