Skip to content

Commit ae8a129

Browse files
committed
chore: Remove firmware type label from sidebar online status
- Drop firmware variant display (RS-Key/pico-fido) in sidebar status footer - Rename workflow job to verify-build
1 parent 8f32c7c commit ae8a129

3 files changed

Lines changed: 5 additions & 15 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ jobs:
4343
- name: Run tests
4444
run: nix develop --command cargo test --verbose
4545

46-
build-matrix:
46+
verify-build:
4747
name: Build (${{ matrix.platform }} / ${{ matrix.target }})
4848
needs: checks
4949
strategy:

src/hal/types.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ pub enum FirmwareType {
104104
impl fmt::Display for FirmwareType {
105105
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
106106
match self {
107-
Self::PicoFido => write!(f, "Pico-FIDO"),
107+
Self::PicoFido => write!(f, "pico-fido"),
108108
Self::RSKey => write!(f, "RS-Key"),
109109
Self::Unknown => write!(f, "Unknown"),
110110
}

src/ui/components/sidebar.rs

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
use crate::ui::app::Destination;
22
use crate::ui::components::button::PFIconButton;
3-
use crate::ui::models::device::{DeviceMethod, DeviceRepo, FirmwareType};
3+
use crate::ui::models::device::{DeviceMethod, DeviceRepo};
44
use gpui::*;
55
use gpui_component::{
66
ActiveTheme, Icon, IconName, Side,
@@ -252,20 +252,10 @@ impl Render for AppSidebar {
252252
)
253253
.child({
254254
let (text, color_bg, color_text) = if let Some(s) = &status_owned {
255-
let is_rskey = s.firmware_type == FirmwareType::RSKey;
256-
let fw_label = if is_rskey { "RS-Key" } else { "Pico-FIDO" };
257255
if s.method == DeviceMethod::Fido {
258-
(
259-
format!("Online - FIDO ({})", fw_label),
260-
rgb(0xf59e0b),
261-
rgb(0xffffff),
262-
)
256+
("Online - FIDO".to_string(), rgb(0xf59e0b), rgb(0xffffff))
263257
} else {
264-
(
265-
format!("Online - {}", fw_label),
266-
rgb(0x16a34a),
267-
rgb(0xffffff),
268-
)
258+
("Online".to_string(), rgb(0x16a34a), rgb(0xffffff))
269259
}
270260
} else if error_owned.is_some() {
271261
("Error".to_string(), rgb(0xd97706), rgb(0xffffff))

0 commit comments

Comments
 (0)