Use generaltable for discussionlist and use generic css classes

Author: justusdieckmann

locallib.php

@@ -177,7 +177,6 @@ function moodleoverflow_print_latest_discussions($moodleoverflow, $cm, $page = -
 
     // Iterate through every visible discussion.
     $i = 0;
-    $rowcount = 0;
     $preparedarray = array();
     foreach ($discussions as $discussion) {
         $preparedarray[$i] = array();
@@ -245,9 +244,6 @@ function moodleoverflow_print_latest_discussions($moodleoverflow, $cm, $page = -
         // Use the discussions name instead of the subject of the first post.
         $discussion->subject = $discussion->name;
 
-        // Increase the rowcount.
-        $rowcount = ($rowcount + 1) % 2;
-
         // Format the subjectname and the link to the topic.
         $preparedarray[$i]['subjecttext'] = format_string($discussion->subject);
         $preparedarray[$i]['subjectlink'] = $CFG->wwwroot . '/mod/moodleoverflow/discussion.php?d=' . $discussion->discussion;
@@ -334,7 +330,6 @@ function moodleoverflow_print_latest_discussions($moodleoverflow, $cm, $page = -
 
         // Add all created data to an array.
 
-        $preparedarray[$i]['rowcount'] = $rowcount;
         $preparedarray[$i]['statusstarter'] = $statusstarter;
         $preparedarray[$i]['statusteacher'] = $statusteacher;
         $preparedarray[$i]['statusboth'] = $statusboth;

styles.css

@@ -12,18 +12,6 @@
 /*
  * The discussionlist in the view.php
  */
-.moodleoverflowheaderlist {
-    border-collapse: separate;
-    border-style: solid;
-    border-width: 1px;
-    margin-top: 10px;
-    width: 100%;
-}
-
-.moodleoverflowheaderlist td {
-    border-style: solid;
-    border-width: 1px 0 0 1px;
-}
 
 .moodleoverflowheaderlist th.header.replies .iconsmall {
     margin: 0 .3em;
@@ -55,64 +43,6 @@
     text-align: center;
 }
 
-.moodleoverflowheaderlist tbody tr:nth-of-type(odd) {
-    background-color: #fafafa;
-}
-
-.moodleoverflowheaderlist {
-    background-color: #f9feff;
-}
-
-.moodleoverflowheaderlist .table-active:hover {
-    background-color: #dff8ff;
-}
-
-.moodleoverflowheaderlist .table-active:hover > td,
-.moodleoverflowheaderlist .table-active:hover > th {
-    background-color: #dff8ff;
-}
-
-.moodleoverflowheaderlist .table-success:hover {
-    background-color: #d0e9c6;
-}
-
-.moodleoverflowheaderlist .table-success:hover > td,
-.moodleoverflowheaderlist .table-success:hover > th {
-    background-color: #d0e9c6;
-}
-
-.moodleoverflowheaderlist .table-info:hover {
-    background-color: #c4e3f3;
-}
-
-.moodleoverflowheaderlist .table-info:hover > td,
-.moodleoverflowheaderlist .table-info:hover > th {
-    background-color: #c4e3f3;
-}
-
-.moodleoverflowheaderlist .table-warning:hover {
-    background-color: #faf2cc;
-}
-
-.moodleoverflowheaderlist .table-warning:hover > td,
-.moodleoverflowheaderlist .table-warning:hover > th {
-    background-color: #faf2cc;
-}
-
-.moodleoverflowheaderlist .table-danger:hover {
-    background-color: #ebcccc;
-}
-
-.moodleoverflowheaderlist .table-danger:hover > td,
-.moodleoverflowheaderlist .table-danger:hover > th {
-    background-color: #ebcccc;
-}
-
-.moodleoverflowheaderlist,
-.moodleoverflowheaderlist td {
-    border: none;
-}
-
 .moodleoverflowheaderlist thead .header,
 .moodleoverflowheaderlist tbody .discussion td {
     padding-left: .5em;
@@ -292,8 +222,6 @@
 }
 
 .moodleoverflowpost {
-    background-color: #fff;
-    border: 1px solid rgba(238, 238, 238, 1);
     border-radius: 0;
     display: block;
     margin-bottom: 5px;

templates/answer.mustache

@@ -34,7 +34,7 @@
 <a id="p{{ postid }}"></a>
 
 {{! Start the post. Mark it read or unread. }}
-<div class="moodleoverflowpost clearfix{{ postclass }}{{# isfirstpost}} firstpost starter{{/isfirstpost}}" role="region" aria-label="{{ discussionby }}">
+<div class="moodleoverflowpost border clearfix{{ postclass }}{{# isfirstpost}} firstpost starter{{/isfirstpost}}" role="region" aria-label="{{ discussionby }}">
 
     <table>
         <tbody>

templates/discussion_list.mustache

@@ -35,7 +35,7 @@
 {{! There are discussions. Start to print the table. }}
 {{#hasdiscussions}}
 
-    <table cellspacing="0" class="moodleoverflowheaderlist">
+    <table cellspacing="0" class="moodleoverflowheaderlist generaltable">
 
         {{! Print the heading row of the table. }}
         <thead>
@@ -95,7 +95,7 @@
 
         {{! Loop through all discussions. }}
         {{#discussions}}
-            <tr class="discussion r{{ rowcount }}">
+            <tr class="discussion">
 
                 {{! The status of the discussion. }}
                 <td class="topic replies">

templates/post_dummy_cantsee.mustache

@@ -27,7 +27,7 @@
 
 <a id="p{{ postid }}"></a>
 
-<div class="moodleoverflowpost clearfix" role="region" aria-label="{{# str}} hiddenmoodleoverflowpost, moodleoverflow {{/str}}">
+<div class="moodleoverflowpost border clearfix" role="region" aria-label="{{# str}} hiddenmoodleoverflowpost, moodleoverflow {{/str}}">
 
     {{! The heading row. }}
     <div class="row header">

templates/question.mustache

@@ -34,7 +34,7 @@
 <a id="p{{ postid }}"></a>
 
 {{! Start the post. Mark it read or unread. }}
-<div class="moodleoverflowpost clearfix{{ postclass }}{{# isfirstpost}} firstpost starter{{/isfirstpost}}" role="region"
+<div class="moodleoverflowpost border clearfix{{ postclass }}{{# isfirstpost}} firstpost starter{{/isfirstpost}}" role="region"
      aria-label="{{ discussionby }}">
 
     <div>