Reorder function arguments

Author: justusdieckmann

discussion.php

@@ -105,7 +105,7 @@
 }
 
 // Has the user the capability to view the post?
-if (!moodleoverflow_user_can_see_post($moodleoverflow, $discussion, $post, null, $cm)) {
+if (!moodleoverflow_user_can_see_post($moodleoverflow, $discussion, $post, $cm)) {
     throw new moodle_exception('noviewdiscussionspermission', 'moodleoverflow',
         "$CFG->wwwroot/mod/moodleoverflow/view.php?m=$moodleoverflow->id");
 }

lib.php

@@ -448,7 +448,7 @@ function moodleoverflow_pluginfile($course, $cm, $context, $filearea, array $arg
     }
 
     // Make sure we're allowed to see it...
-    if (!moodleoverflow_user_can_see_post($moodleoverflow, $discussion, $post, null, $cm)) {
+    if (!moodleoverflow_user_can_see_post($moodleoverflow, $discussion, $post, $cm)) {
         return false;
     }
 
@@ -827,7 +827,7 @@ function moodleoverflow_send_mails() {
                 }
 
                 // Make sure the current user is allowed to see the post.
-                if (!moodleoverflow_user_can_see_post($moodleoverflow, $discussion, $post, null, $cm)) {
+                if (!moodleoverflow_user_can_see_post($moodleoverflow, $discussion, $post, $cm)) {
                     mtrace('User ' . $userto->id . ' can not see ' . $post->id . '. Not sending message.');
                     continue;
                 }

locallib.php

@@ -515,12 +515,12 @@ function moodleoverflow_get_post_full($postid) {
  * @param object $moodleoverflow
  * @param object $discussion
  * @param object $post
- * @param null   $user
  * @param object $cm
+ * @param null   $user
  *
  * @return bool
  */
-function moodleoverflow_user_can_see_post($moodleoverflow, $discussion, $post, $user = null, $cm) {
+function moodleoverflow_user_can_see_post($moodleoverflow, $discussion, $post, $cm, $user = null) {
     global $USER, $DB;
 
     // Retrieve the modulecontext.
@@ -1044,7 +1044,7 @@ function moodleoverflow_print_post($post, $discussion, $moodleoverflow, $cm, $co
     }
 
     // Check if the user has the capability to see posts.
-    if (!moodleoverflow_user_can_see_post($moodleoverflow, $discussion, $post, null, $cm)) {
+    if (!moodleoverflow_user_can_see_post($moodleoverflow, $discussion, $post, $cm)) {
 
         // No dummy message is requested.
         if (!$dummyifcantsee) {