From 5c90d00ce278404e6fe64a6eb755f9bffec54971 Mon Sep 17 00:00:00 2001
From: artiomtr <44021713+ArtiomTr@users.noreply.github.com>
Date: Tue, 3 Feb 2026 16:37:45 +0200
Subject: [PATCH] Minor metrics specification fixes

* Renamed `lean_pq_sig_attestation_signing_time_seconds` to
  `lean_pq_signature_attestation_signing_time_seconds` and
  `lean_pq_sig_attestation_verification_time_seconds` to
  `lean_pq_signature_attestation_verification_time_seconds`, as those
  are the metric names that grafana dashboard in
  development/client-dashboard.json references, as well as what both
  ream and zeam implement;
* removed buckets from `lean_pq_sig_aggregated_signatures_total` and
  `lean_pq_sig_attestations_in_aggregated_signatures_total` metrics, as
  those have `Counter` type;
* fixed `lean_pq_sig_attestation_signatures_building_time_seconds`
  metric description, to say "build" instead of "verify" signature;
* for aggregate signature metrics, changed event from
  "On `build_attestation_signatures()`" to "On aggregated attestation
  production", as this function in specification is used only for tests.
---
 metrics.md | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/metrics.md b/metrics.md
index ef3510b..d0a608c 100644
--- a/metrics.md
+++ b/metrics.md
@@ -20,11 +20,11 @@
 
 | Name   | Type  | Usage | Sample collection event | Labels | Buckets | Lantern  | Qlean    | Ream     | Zeam     |
 |--------|-------|-------|-------------------------|--------|---------|----------|----------|----------|----------|
-| `lean_pq_sig_attestation_signing_time_seconds` | Histogram | Time taken to sign an attestation | On each attestation signing | | 0.005, 0.01, 0.025, 0.05, 0.1, 1 | □ | □ | ✅ | □ |
-| `lean_pq_sig_attestation_verification_time_seconds` | Histogram | Time taken to verify an attestation signature | On each `signature.verify()` on an attestation | | 0.005, 0.01, 0.025, 0.05, 0.1, 1 | □ | □ | ✅ | □ |
-| `lean_pq_sig_aggregated_signatures_total` | Counter | Total number of aggregated signatures | On `build_attestation_signatures()` | | 0.005, 0.01, 0.025, 0.05, 0.1, 1 | □ | □ | □ | □ |
-| `lean_pq_sig_attestations_in_aggregated_signatures_total` | Counter | Total number of attestations included into aggregated signatures | On `build_attestation_signatures()` | | 0.005, 0.01, 0.025, 0.05, 0.1, 1 | □ | □ | □ | □ |
-| `lean_pq_sig_attestation_signatures_building_time_seconds` | Histogram | Time taken to verify an aggregated attestation signature | On `build_attestation_signatures()` | | 0.005, 0.01, 0.025, 0.05, 0.1, 1 | □ | □ | □ | □ |
+| `lean_pq_signature_attestation_signing_time_seconds` | Histogram | Time taken to sign an attestation | On each attestation signing | | 0.005, 0.01, 0.025, 0.05, 0.1, 1 | □ | □ | ✅ | □ |
+| `lean_pq_signature_attestation_verification_time_seconds` | Histogram | Time taken to verify an attestation signature | On each `signature.verify()` on an attestation | | 0.005, 0.01, 0.025, 0.05, 0.1, 1 | □ | □ | ✅ | □ |
+| `lean_pq_sig_aggregated_signatures_total` | Counter | Total number of aggregated signatures | On aggregated signature production | | | □ | □ | □ | □ |
+| `lean_pq_sig_attestations_in_aggregated_signatures_total` | Counter | Total number of attestations included into aggregated signatures | On aggregated attestation production | | | □ | □ | □ | □ |
+| `lean_pq_sig_attestation_signatures_building_time_seconds` | Histogram | Time taken to build an aggregated attestation signature | On aggregated signature production | | 0.005, 0.01, 0.025, 0.05, 0.1, 1 | □ | □ | □ | □ |
 | `lean_pq_sig_aggregated_signatures_verification_time_seconds` | Histogram | Time taken to verify an aggregated attestation signature | On validate aggregated signature | | 0.005, 0.01, 0.025, 0.05, 0.1, 1 | □ | □ | □ | □ |
 | `lean_pq_sig_aggregated_signatures_valid_total`| Counter | Total number of valid aggregated signatures | On validate aggregated signature | | | □ | □ | □ | □ |
 | `lean_pq_sig_aggregated_signatures_invalid_total`| Counter | Total number of invalid aggregated signatures | On validate aggregated signature | | | □ | □ | □ | □ |