fix(l1): improve import benchmark #5525
Merged
+34
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit dd3b4b0.
MegaRedHand
added
tech debt
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the usability of the import benchmark tooling by fixing path handling issues and making the scripts more flexible.
- Modified
benchmark.shto output results totooling/import_benchmark/bench_resultsdirectory and correctly determine the next bench ID - Updated
parse_bench.pyto accept file paths directly as arguments instead of numeric ranges, making it more flexible and removing the unused numpy dependency - Updated documentation in README.md and Makefile to reflect the new command-line interface
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tooling/import_benchmark/parse_bench.py | Refactored to accept file paths as arguments instead of numeric ranges; removed unused numpy import; improved code formatting |
| tooling/import_benchmark/benchmark.sh | Added logic to determine script directory, create bench_results directory, and output logs to the correct location |
| tooling/import_benchmark/README.md | Updated usage documentation to reflect new file path-based argument passing |
| tooling/import_benchmark/Makefile | Updated help text to document the new command-line interface for parse_bench.py |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
pablodeymo
approved these changes
Dec 4, 2025
Oppen
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The import benchmark doesn't work out of the box, and has some quirks that can be easily fixed.
Description
This PR changes the
benchmark.shscript so it outputs results intotooling/import_benchmark/bench_results. It now also uses the correct directory to find the highest bench ID.Also, the Python script to parse results was difficult to use, since the results needed to be in the repo root; otherwise, it wouldn't work. Now it receives the file paths directly, which is more flexible and straightforward. Additionally, numpy was removed as a dependency, since it was unused.