feat(l1): pin execution-apis version when running rpc-compat hive suite in Makefile targets
#5463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoletta
changed the title
execution-apis version for rpc-compat hive Makefile targetsexecution-apis version when running rpc-compat hive suite in Makefile targets
fmoletta
changed the title
execution-apis version when running rpc-compat hive suite in Makefile targetsexecution-apis version when running rpc-compat hive suite in Makefile targets
MegaRedHand
reviewed
Nov 28, 2025
| SIM_PARALLELISM ?= 16 | ||
| # https://github.com/ethereum/execution-apis/pull/627 changed the simulation to use a pre-merge genesis block, so we need to pin to a commit before that | ||
| ifeq ( $(SIMULATION) , ethereum/rpc-compat ) | ||
| SIM_BUILDARG_FLAG = --sim.buildarg "branch=d08382ae5c808680e976fce4b73f4ba91647199b" |
Collaborator
There was a problem hiding this comment.
This commit is from nearly a year ago, right? Does it make sense to try to update this to the latest commit?
Contributor
Author
There was a problem hiding this comment.
The latest commit uses a post-merge genesis file so we cannot use it. The pinned commit is the latest one before the PR that changed the genesis file (the one linked) was merged, me cannot use a newer commit. The pinned commit is from 10 months ago.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the hive workflow that runs for each PR, we set the execution-apis version as a building when running
rpc-compattesting suite, as the latest version uses a pre-merge genesis file. This causes hive tests to pass on the CI but not when developing locally. This PR fixes this by adding the buildarg flag when running rpc-compat testing suite