Skip to content

perf(l1): avoid heap alloc in tx compute_hash #5457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

perf(l1): avoid heap alloc in tx compute_hash #5457

wants to merge 5 commits into from
+85 −3

Conversation

@edg-l
Copy link
Contributor

@edg-l edg-l commented Nov 28, 2025 •
edited
Loading

Added HashBuffer, this is a buffer that implements BufMut and feeds data to a keccak256 hasher, this way we avoid a temporary vec when computing hash of transactions.

A quick bench shows it goes from 4.70s to 4.28s in 10000000 iterations

@github-actions github-actions bot added L1 Ethereum client performance Block execution throughput and performance in general labels Nov 28, 2025
@github-actions
Copy link

github-actions bot commented Nov 28, 2025 •
edited
Loading

Lines of code report

Total lines added: 68
Total lines removed: 0
Total lines changed: 68

Detailed view 
+-------------------------------------------+-------+------+
| File                                      | Lines | Diff |
+-------------------------------------------+-------+------+
| ethrex/crates/common/types/transaction.rs | 3248  | +5   |
+-------------------------------------------+-------+------+
| ethrex/crates/common/utils.rs             | 131   | +63  |
+-------------------------------------------+-------+------+

Oppen
Oppen reviewed Nov 28, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Nov 28, 2025 •
edited
Loading

Benchmark Block Execution Results Comparison Against Main

Command Mean [s] Min [s] Max [s] Relative
base 61.573 ± 0.490 60.851 62.290 1.00 ± 0.01
head 61.272 ± 0.290 60.869 61.863 1.00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Oppen Oppen Oppen left review comments

@ilitteri ilitteri Awaiting requested review from ilitteri ilitteri will be requested when the pull request is marked ready for review ilitteri is a code owner

@ManuelBilbao ManuelBilbao Awaiting requested review from ManuelBilbao ManuelBilbao will be requested when the pull request is marked ready for review ManuelBilbao is a code owner

@avilagaston9 avilagaston9 Awaiting requested review from avilagaston9 avilagaston9 will be requested when the pull request is marked ready for review avilagaston9 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@edg-l edg-l

Labels

L1 Ethereum client performance Block execution throughput and performance in general

Projects

ethrex_l1
Status: No status
ethrex_performance
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edg-l @Oppen